fix(vehicle velocity converter): suppress warnings (autowarefoundatio…

…n#295) * feat: add Werror Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * fix: fix deprecated-declarations Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
badai-nguyen · Feb 2, 2022 · 7f21872 · 7f21872
1 parent 31e7748
commit 7f21872
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/localization/vehicle_velocity_converter/CMakeLists.txt b/localization/vehicle_velocity_converter/CMakeLists.txt
@@ -8,8 +8,7 @@ if(NOT CMAKE_CXX_STANDARD)
   set(CMAKE_CXX_EXTENSIONS OFF)
 endif()
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  # add_compile_options(-Wall -Wextra -Wpedantic)
-  add_compile_options(-Wno-unused-parameter)
+  add_compile_options(-Wall -Wextra -Wpedantic -Werror)
 endif()
 
 # find dependencies

diff --git a/localization/vehicle_velocity_converter/src/vehicle_velocity_converter.cpp b/localization/vehicle_velocity_converter/src/vehicle_velocity_converter.cpp
@@ -17,8 +17,7 @@
 VehicleVelocityConverter::VehicleVelocityConverter() : Node("vehicle_velocity_converter")
 {
   // set covariance value for twist with covariance msg
-  declare_parameter("twist_covariance");
-  std::vector<double> covariance = get_parameter("twist_covariance").as_double_array();
+  std::vector<double> covariance = declare_parameter<std::vector<double>>("twist_covariance");
   for (std::size_t i = 0; i < covariance.size(); ++i) {
     twist_covariance_[i] = covariance[i];
   }