Deploy Checklist: Expensify.cash 2021-06-08

[OSBotify]

Release Version: 1.0.68-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Upgrade react-navigation to 6.x #3078
• See extra fields per chat #3095
• Bump react-native-web to 0.15.7 react to 17.0.2 #3215
• [No QA] Improved permission checking #3321
• File upload failure checking #3332
• [IS-3186] Fixed cursor position issue on Android #3374
• Update merge-deep per SNYK-JS-MERGEDEEP-1070277 #3409
• iOS - Plus green button isn't announced via Voiceover #3415
• fixed edited flag is shown for brief moment #3421
• Update react-native-onyx with the latest version #3423
• Fix regression with default option selection #3426
• [IS-3218] Fixed cursor issue on edit comment box #3434
• Apply localization to all hard coded text in the Expensify.cash app #3435
• Rename AddBankAccountPage to AddPersonalBankAccountPage #3443
• Use VERSION_CODE instead of VERSION #3445
• Update react-native for SNYK vulnerability #3446
• Fix versionCode regex to work on ubuntu #3456
• Add VBA flow Part 1 #3459
• Update Permissions logic to fix IOU regression #3481
• [NO-QA] Bump Onyx commit to fix IOU regression #3483
• Use hrefAttrs for links #3486
• [No QA] Single brackets not double brackets #3491
• [No QA] Push changes before trying to create CP branch #3493
• Fix line breaks in homepage links #3502
• Upgrade the urbanairship-react-native package #3508
• [IS-3218] Fixed cursor issue #3510
• Quit early when persistedRequests is empty #3511
• Remove Geolocation library for initial IOU release #3514
• [NO QA] Urgent Fix: Missed passing a parameter to NewchatOptions #3517
• [No QA] Update staging,prod from a separate branch to auto-resolve conflicts #3521
• #3102 add es translation for close #3525
• [No QA] Add committer name #3529
• Make tapping the entire IOU preview component open the IOU Details modal #3541
• Upgrade react-native-document-picker to 5.1.0 #3550
• Add capturing event listeners to the KeyboardShortcut library #3555
• fix: Document Picker crash on IOS #3581

Deploy Blockers:

• Bump react-native-web to 0.15.7 react to 17.0.2 #3215
• [No QA] Improved permission checking #3321
• Update react-native-onyx with the latest version #3423
• [IS-3218] Fixed cursor issue on edit comment box #3434
• IOU - Currencies are not displayed after clicking the currency symbol for a second time #3482
• iOS - App crashes after turning off the internet connection #3485
• Web/mWeb- Sign in - Endless loading spinner appears when re login #3488
• Android - App crashes when logging out #3503
• CMD + K is not working when the focus is on compose box #3512
• App freezes after reopening it from background after a while #3536
• Push Notification not received if app is backgrounded #3542
• [HOLD for payment 21 June] iOS - Attachment picker flickers and unable to select for choose document #3543
• Tapping on Edit Message scrolls down to the bottom to the compose box #3545

cc @Expensify/applauseleads

[isagoico]

Starting QA

[isagoico]

Should I check these off #3456 and #3445 and test them when the prod build is deployed? CC @AndrewGable @roryabraham

[roryabraham]

Should I check these off #3456 and #3445 and test them when the prod build is deployed?

Yep! Just ping us before you run the next prod deploy and we'll verify that it worked. No worries, it's unlikely those PRs will break android prod deploys any more than they're already broken.

[isagoico]

Regression is finished
3 issues found:

1. iOS - App crashes after turning off the internet connection #3485
2. Web/mWeb- Sign in - Endless loading spinner appears when re login #3488
3. Android - App crashes when logging out #3503

PRs are finished.
2 comments added:

1. [IS-3218] Fixed cursor issue on edit comment box #3434 (comment) will be fixed in Set the focus on Edit Box after edit action. #3441
2. [IS-3218] Fixed cursor issue on edit comment box #3434 (comment)

Thanks!

[isagoico]

@roryabraham haven't added the DB label yet since there haven't been any changes

[roryabraham]

@isagoico I'm investigating why there haven't been any changes here – there have been PRs merged since this was unlocked, which should update this issue.

[isagoico]

Oh y yeah I found it really weird that no changes were disolayed. Let me know when we can start QA.

[roryabraham]

Looks like CP's may have broken the normal deploy workflow in an unexpected way – this version-bump PR includes changes that it should not, and has merge conflicts in the normal version-bump files

[stitesExpensify]

Checking off #3512 in the deploy blocker section, we're not going to block on it.

[roryabraham]

Okay, staging deploys are fixed now, but I'm going to have to manually update the checklist. It's missing PRs, but I have a PR here that should make it more robust and self-correcting in the future.

[isagoico]

Starting QA

[roryabraham]

Adding the following PRs:

• File upload failure checking #3332
• Update Permissions logic to fix IOU regression #3481
• [NO-QA] Bump Onyx commit to fix IOU regression #3483
• Use hrefAttrs for links #3486
• [No QA] Single brackets not double brackets #3491
• [No QA] Push changes before trying to create CP branch #3493
• Fix line breaks in homepage links #3502
• Upgrade the urbanairship-react-native package #3508
• [IS-3218] Fixed cursor issue #3510
• Quit early when persistedRequests is empty #3511
• [NO QA] Urgent Fix: Missed passing a parameter to NewchatOptions #3517
• [No QA] Update staging,prod from a separate branch to auto-resolve conflicts #3521

[roryabraham]

So @isagoico and I discussed this 1:1 a bit, but I just wanted to make a note of it here. Since Applause is starting QA so late in the day, @isagoico didn't want to guarantee 100% completion. So we aren't going to run a production deploy today, but we still wanted to get a QA cycle in so that we'll know ASAP if there are any new deploy blockers or regressions that need to be addressed.

[isagoico]

Regression is finished.
Issues found today:

1. [HOLD for payment 21 June] iOS - Attachment picker flickers and unable to select for choose document #3543
2. App freezes after reopening it from background after a while #3536
3. Android - LHN - Bottom of messages are cutoff #3538
4. After logging in, chat is displayed instead of LHN #3537

PRs are finished too:
2 comments added:

1. Upgrade the urbanairship-react-native package #3508 (comment) > Exported here Push Notification not received if app is backgrounded #3542
2. [IS-3218] Fixed cursor issue #3510 (comment) > Exported here Tapping on Edit Message scrolls down to the bottom to the compose box #3545

We were unable to test this PR in iOS because of the attachment issue #3332 (comment)

Thanks!

[Julesssss]

Resolved #3321 as the fix has been CP'd to staging.

[Julesssss]

Also #3482 & #3485

[Julesssss]

Hey @roryabraham @isagoico. I think we need to keep the LockCashDeploys label attached to this don't we? Else additional PRs will be included as part of this release and might cause further deployBlockers to occur?

[isagoico]

mmm we usually remove the lock label after finishing regression (which it was finished earlier today) if there are deploy blockers during QA, I actually thought I had removed the label earlier today but looks like I didn't 🤦. On my 1:1 with @roryabraham he mentioned that there was not going to be a production deploy but didn't say anything about the lock label.

[roryabraham]

@isagoico, that was my mistake. I think we wanted to leave the lock label to prevent new PRs from being added to the release. Unfortunately we can't undo it at this point, and adding the label back will cause main to be deployed to staging.

Fortunately, we now have the ability to CP fixes to staging, so once the LockCashDeploys is next added to this issue, let's leave it there until we have resolved all deploy blockers via CPs. That way, any newly-merged PRs will be included in the next release instead of this one.

[roryabraham]

Manually added the following PRs which were missing from this checklist:

• Add VBA flow Part 1 #3459
• Remove Geolocation library for initial IOU release #3514
• #3102 add es translation for close #3525
• Make tapping the entire IOU preview component open the IOU Details modal #3541

Note: @AndrewGable @Jag96 This is something I always have to remember to do. PRs merged while the checklist is locked are not added to the checklist when the lock label is removed (only added to the next checklist if we run a prod deploy). But this PR should fix it, so I would love to merge + test that as soon as possible (after our next prod deploy).

[Julesssss]

#3545 was also checked off as we no longer think it needs to block the release.

[roryabraham]

#3550 is being CP'd to staging, should fix #3543 in 1.0.68-1 🤞

Staging deploy happening here

[roryabraham]

CP'ing #3535 to staging: should fix #3488 and #3536 in 1.0.68-3 🤞

[roryabraham]

Build for 1.0.63-3 is running here ... @isagoico when it's done can you please have your testers retest:

• Web/mWeb- Sign in - Endless loading spinner appears when re login #3488
• App freezes after reopening it from background after a while #3536
• [HOLD for payment 21 June] iOS - Attachment picker flickers and unable to select for choose document #3543

🙏

[isagoico]

Regression is finished!
1 issue found today:

1. Web - IOU - Previously used currency appears for a brief moment for request/ split money #3560

PRs are finished too
No comments added 🎉

Thanks!

[isagoico]

#3510 checked off, will be worked on a separate issue

#3215 links are opening in a different tab now so it's a pass 🎉

[isagoico]

@roryabraham: While re testing the deploy blockers we were able to reproduce this issue:

1. When signing into an account after signing out, you are brought to /r/ instead of a chat #3559

#3536 and #3488 were a pass. For #3543 I'm waiting for someone with iOS to check it since I don't have my iOS on my atm.

[isagoico]

#3543 is still reproducible, reopening the issue.

[Julesssss]

Marked #3423 as resolved, as the raised issues were fixed and merged.

[Julesssss]

I removed #3215 from being a deployBlocker, as this comment proves it did not introduce the iOS attachment regression.

[Julesssss]

@isagoico I am happy to confirm all deployBlockers have been resolved

[isagoico]

That's great news 🎉 are you guys gonna try a production deploy?

[roryabraham]

I think so ... pending the 👍 from @trjExpensify

[trjExpensify]

Yep, let's do it! 👍

[Julesssss]