Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-native-document-picker to 5.1.0 #3550

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Upgrade react-native-document-picker to 5.1.0 #3550

merged 1 commit into from
Jun 11, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jun 11, 2021 •
edited
Loading

cc @marcaaron @cead22

Details

Not sure why, but this does seem to resolve the issue for me.

Fixed Issues

Fixes #3543

Tests / QA Steps

  1. Hit the +, then select Upload Attachment
  2. Then choose Choose Document
  3. Verify that the document picker opens and that you can choose and upload a document.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

image

Desktop

image

iOS

image

image

image

Android

image

image

@roryabraham roryabraham requested a review from a team as a code owner June 11, 2021 18:07
@roryabraham roryabraham self-assigned this Jun 11, 2021
@MelvinBot MelvinBot requested review from mountiny and removed request for a team June 11, 2021 18:07
@roryabraham roryabraham requested a review from a team June 11, 2021 18:23
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team June 11, 2021 18:24
@roryabraham
Copy link
Contributor Author

All three of my reviewers are likely out for the day, and I'd like to get this reviewed and merged ASAP because it resolves a deploy blocker.

@roryabraham roryabraham requested review from a team and removed request for Julesssss, mountiny and HorusGoul June 11, 2021 18:29
@MelvinBot MelvinBot requested review from mountiny and removed request for a team June 11, 2021 18:30
@marcaaron
Copy link
Contributor

Testing now @roryabraham

@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

marcaaron
marcaaron approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't able to repro on the following:

Simulator (iPhone 12/iOS 14.5)
Android (Galaxy S8 - physical)
iPad mini 2 (iOS 12.5.1 - physical)

:shipit: ❓

@roryabraham roryabraham merged commit 3e2f266 into main Jun 11, 2021
@roryabraham roryabraham deleted the Rory-Upgrade-react-native-document-picker branch June 11, 2021 18:38
@roryabraham
Copy link
Contributor Author

:shipit:

@roryabraham roryabraham mentioned this pull request Jun 11, 2021
Closed
49 tasks
github-actions bot pushed a commit that referenced this pull request Jun 11, 2021
@roryabraham
Merge pull request #3550 from Expensify/Rory-Upgrade-react-native-doc…
6368086 
…ument-picker

Upgrade react-native-document-picker to 5.1.0

(cherry picked from commit 3e2f266)
@OSBotify OSBotify mentioned this pull request Jun 11, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.68-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mountiny mountiny removed their request for review June 11, 2021 20:43
@Julesssss
Copy link
Contributor

Julesssss commented Jun 14, 2021 •
edited
Loading

Thanks for prioritizing this!

@OSBotify OSBotify mentioned this pull request Jun 15, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.68-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Jun 25, 2021
Closed
Closed
This was referenced Jul 7, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Jul 14, 2021
Closed
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cead22 cead22 cead22 approved these changes

@marcaaron marcaaron marcaaron approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HOLD for payment 21 June] iOS - Attachment picker flickers and unable to select for choose document
5 participants
@roryabraham @marcaaron @OSBotify @Julesssss @cead22