Deploy Checklist: Expensify.cash 2021-06-29

[OSBotify]

Release Version: 1.0.75-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix contextMenu on Mobile #3659
• Extended Drop area to report 🗒️ body for attachment #3732
• Create the Report Details Page #3742
• Cache node_modules/gems/pods in workflows #3752
• New keyboard shortcut for new Group chat #3754
• Fix Desktop - CMD + K is slow and laggy #3601 #3760
• Fix up workspace routes #3763
• Disable next button on invalid amount. #3765
• Start accounting for notificationPreferences in the unread indicator for Chat Rooms #3766
• Fixed StagingDeployCash issue body #3772
• Allow those in defaultRooms beta to also load policies #3780
• [No QA] Change E.cash platform specific file extension docs  #3794
• [No QA] Use regular function instead of arrow function #3795
• #2973 set input height to 42 #3805
• Revert suppression of touchstart to fix regressions #3816
• [CP Staging] Revert "Fix Desktop - CMD + K is slow and laggy #3601" #3824
• Start including betas in the call to getSidebarOptions #3840

Deploy Blockers:

• Search for participant is not working  #3818
• Chat switching using arrow keys does not open correct chat #3821
• mWeb - Chat - "View details" in chat is not responding #3826
• mWeb - Chat - Unable to click on any attachments #3827
• mWeb - Chat - Pay button isn't responding in chat conversation #3828

cc @Expensify/applauseleads

[roryabraham]

Confirmed that all these issues were correctly added to this checklist 👍

[isagoico]

Nice! We are good to start QA right?

[roryabraham]

Yep, you're good to begin QA as soon as you're ready

[roryabraham]

So this workflow seems to have added way too many issues to this checklist. I've been doing my best to diagnose it, but as far as I can tell it seems like this is the line where it really went wrong.

[roryabraham]

Here's the source of our error:

And then the code where that happens is right here. So it seems that newVersion is being passed to GitUtils.getPullRequestsMergedBetween as null or and empty string. It in turn comes from here, and we can see from the workflow run logs that the input was passed correctly. Which leads me to believe this might be a glitch or bug in GH Actions?

[mvtglobally]

Starting QA

[mvtglobally]

@roryabraham We will work through the top list. If any PRs need to be removed, let us know.
We will wait for 1.0.75

[roryabraham]

I just removed a bunch from the list. Working on trying to fix the checklist in the meantime

[roryabraham]

Manually removing a bunch more

[isagoico]

Regression is finished!
Issues found:

1. mWeb - Chat - Pay button isn't responding in chat conversation #3828 - Resolved
2. Desktop - Split money - Selected attendees not moved above recents header #3829 - Resolved
3. [HOLD - for payment on July 14] Chat - Loading spinner appears after log in with different account #3838
4. mWeb - Chat - Unable to click on any attachments #3827 - Deploy Blocker
5. mWeb - Chat - "View details" in chat is not responding #3826 - Resolved

PRs are finished too:
Comments added:

1. fix contextMenu on Mobile #3659 (comment) - Resolved
2. Create the Report Details Page #3742 (comment) - We were blocked from testing this PR
3. Start accounting for notificationPreferences in the unread indicator for Chat Rooms #3766 (comment) We were blocked from testing this PR

These PRs were tested on this round (adding this for reference since a bunch were added in the middle of the regression):

• fix contextMenu on Mobile #3659
• Extended Drop area to report 🗒️ body for attachment #3732
• New keyboard shortcut for new Group chat #3754
• Fix up workspace routes #3763
• Disable next button on invalid amount. #3765
• #2973 set input height to 42 #3805
• Create the Report Details Page #3742
• Start accounting for notificationPreferences in the unread indicator for Chat Rooms #3766

Thanks!

[isagoico]

#3766 (comment) Checking it off!

[isagoico]

#3742 Was also a pass!

@roryabraham This checklist has a lot of PRs that were added when the Lock Label was on. Let us known if we should test them. Also All deploy blockers (so far) have been resolved 🎉

[roryabraham]

@isagoico Sorry for the delayed response, I have a PR up to hopefully fix the recent regressions with the deploy checklist. All the PRs in the current state of the checklist have been deployed, and I removed others that were added in error.

So tomorrow, let's plan on leaving the lock label in place and running a regular QA cycle. If there are no deploy blockers, we can run a production deploy as usual. Thanks and sorry for the inconvenience.

[mvtglobally]

Starting QA

[isagoico]

Regression is finished!
2 issues found today:

1. Android - Attachments Preview - Header overlaps Android top status bar #3900
2. [Hold for Payment - Sep 7th] Web - Attachments Preview - Zooming in the edges of an image will lead to white spaces #3901

PRs are finished too.
No comments added 🎉 🎉

Thanks!
ing the issue

[isagoico]