Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start including betas in the call to getSidebarOptions #3840

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Start including betas in the call to getSidebarOptions #3840

merged 1 commit into from
Jun 30, 2021

Conversation

yuwenmemon
Copy link
Contributor

@yuwenmemon yuwenmemon commented Jun 30, 2021 •
edited
Loading

@TomatoToaster please review

Details

This fixes the issue of the #admins rooms not showing up in the LHN. It's because the betas param was not being passed to getSidebarOptions. Thus, it was mistakenly assumed that we were not on the beta.

Fixed Issues

  • N/A just noticed in the public testing of the default rooms.

Tests

  • Send a message in a default room (#admins or #announce), make sure that the default room shows up in the LHN:

Screen Shot 2021-06-30 at 1 37 49 PM

@yuwenmemon yuwenmemon self-assigned this Jun 30, 2021
@yuwenmemon yuwenmemon requested a review from a team as a code owner June 30, 2021 20:48
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from joelbettner and removed request for a team June 30, 2021 20:48
TomatoToaster
TomatoToaster approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this was working locally only before, but great find!

Oh duh because of this: https://github.com/Expensify/Expensify.cash/blob/1275f58c4a171c03cbe01e7fa14cebcfdb280f85/src/libs/Permissions.js#L11

@yuwenmemon yuwenmemon merged commit d627947 into main Jun 30, 2021
@yuwenmemon yuwenmemon deleted the yuwen-sidebarOptionsBetas branch June 30, 2021 22:16
github-actions bot pushed a commit that referenced this pull request Jun 30, 2021
@yuwenmemon
Merge pull request #3840 from Expensify/yuwen-sidebarOptionsBetas
e03643c 
Start including betas in the call to getSidebarOptions

(cherry picked from commit d627947)
This was referenced Jun 30, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.75-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Jul 7, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Jul 14, 2021
Closed
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomatoToaster TomatoToaster TomatoToaster approved these changes

@joelbettner joelbettner Awaiting requested review from joelbettner

Assignees

@yuwenmemon yuwenmemon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwenmemon @OSBotify @TomatoToaster