Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - LHN - Bottom of messages are cutoff #3538

Closed
kavimuru opened this issue Jun 11, 2021 · 12 comments
Closed

Android - LHN - Bottom of messages are cutoff #3538

kavimuru opened this issue Jun 11, 2021 · 12 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Jun 11, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

The text and emojis in messages are properly displayed

Actual Result:

The bottom of the messages are cut off

Action Performed:

  1. Open app and login
  2. Observe the chats in the LHN

Workaround:

Visual

Platform:

Where is this issue occurring?

Web
iOS
Android✔️
Desktop App
Mobile Web

Version Number: 1.0.67-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@nickmurray47 nickmurray47 added the External Added to denote the issue can be worked on by a contributor label Jun 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@isagoico
Copy link

Issue reproducible today during KI retests

@puneetlath
Copy link
Contributor

Going to be mostly OOO this week, so reapplying label so someone else can take it.

@puneetlath puneetlath removed the External Added to denote the issue can be worked on by a contributor label Jun 13, 2021
@puneetlath puneetlath removed their assignment Jun 13, 2021
@puneetlath puneetlath added the External Added to denote the issue can be worked on by a contributor label Jun 13, 2021
@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@aliabbasmalik8
Copy link
Contributor

aliabbasmalik8 commented Jun 14, 2021

@kavimuru
I've seen the USER NAME and First Message inline on the latest main branch.

so there is any other requirement on how to produce this issue?

image

@isagoico
Copy link

isagoico commented Jun 14, 2021

@aliabbasmalik8 I think that's because you have the #Focus enabled in preferences. Can you check?

@aliabbasmalik8
Copy link
Contributor

aliabbasmalik8 commented Jun 14, 2021

This issue not produced but we can fix it by increase the height and line height at this point
https://github.com/Expensify/Expensify.cash/blob/85b22bf9a87f746dae9c2df05bf654730ef018e1/src/styles/styles.js#L691

Here is what I see on android without any code changes.

IMG_20210614_232113

Thanks

@Jag96
Copy link
Contributor

Jag96 commented Jun 15, 2021

@isagoico I'm unable to reproduce this as well, on version 1.0.68-4. What version were you able to reproduce this on yesterday?

image

@shawnborton
Copy link
Contributor

Whoever reported this, can you check to see if you have any kind of font zooming enabled at the device level? Often times that can mess these things up.

@isagoico
Copy link

Yep, im unavle to reproduce either. I'll ask the tester who reported it.

@Jag96
Copy link
Contributor

Jag96 commented Jun 15, 2021

Sounds good, going to close for now, feel free to reopen if this is still an issue!

@Jag96 Jag96 closed this as completed Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

8 participants