CMD + K is not working when the focus is on compose box

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

User should be able to change chats when using the command + k.

Actual Result:

CMD + K is not working when the focus is on compose box.

Action Performed:

1. Log in to e.cash
2. Navigate to a conversation
3. Set the focus to the compose box
4. Hit CMD + K

Workaround:

User has to manually set the focus on the chat switcher

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

**Version Number:**1.0.66-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1623271189154800

CMD+K shortcut is not working when the focus is in the chat text box (tested on web in staging, if this is not happening in prod, we should block deploy on it)

Additional info:
This change was caused by upgrading our react-native-web package to 0.15.7.
It appears that when focused on inputs, all existing keybinds no longer work.

[MelvinBot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[stitesExpensify]

Checked out the commit before bumping the react-native-web version and this bug no longer exists. I'm not sure why that is though

[marcaaron]

I am going to need to have someone else look into this for me for #focus. I'd suggest we maybe create a new issue and move forward with the deploy.

[stitesExpensify]

I think it makes sense to move forward with the deploy, given that we aren't going to roll back react-native-chat. Seems like a good external issue to me as well.

[stitesExpensify]

Removing deploy blocker label and adding external

[MelvinBot]

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[iwiznia]

I disagree about this not being a blocker, I keep sending people messages like brand (because I was trying to switch to the chat with you)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[arielgreen]

I'm a little unclear, should I still get this up on Upwork?

[iwiznia]

I don't know. IMO either we should revert the PR that broke this or fix it. @stitesExpensify why do you say we can't revert the PR that broke this?

[roryabraham]

I think I agree with @stitesExpensify on this one – we probably don't want to revert #3215. We won't be doing a prod deploy today anyways, so we have tomorrow to try and get this fixed, so that would be ideal. But otherwise I think we should just and not treat this as a deploy blocker.

[trjExpensify]

DB's stay internal because they are hourly priority (unless that's changed), so I'm removing the external label for the time being.

I agree with Rory, let's use tomorrow to assess what the fix is for this. If it's straightforward, let's do it and avoid shipping a regression that has a pretty big impact on everyone's productivity in E.cash. If we end up needing more time, then I think we'll need to remove it as a deploy blocker, so that we can get a new prod build to Apple and unblock N5.

[Julesssss]

I also don't think this should be a deployBlocker. But I will take a look at the issue today to see if there's a simple fix.

[Julesssss]

No luck. I added some notes on the PR which introduced this library change. Moving onto other deploy blockers.

[trjExpensify]

👋 @HorusGoul found the fix in this thread. Over to you, @roryabraham!

[roryabraham]

Thanks to @HorusGoul the PR to fix this is ready for review