File upload failure checking #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasharrajat
commented
Jun 3, 2021
parasharrajat
changed the title
parasharrajat
changed the title
|
Ready for review. Thanks. |
ctkochan22
approved these changes
Jun 8, 2021
|
Is there anything left that is preventing it from being merged? |
|
Was waiting on @iwiznia but small change. Looks fine. |
|
Oh sorry, I was not a reviewer, just got pinged to answer a question. |
|
🚀 Deployed to staging in version: 1.0.66-13🚀
|
49 tasks
|
@parasharrajat @ctkochan22 Anything that needs to be QAd here? |
|
Oh yeah @isagoico Updating steps. |
|
Done |
|
We were unable to test this PR in iOS because of this issue #3543. All other environments (Android, Desktop and Web) were a pass. |
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
Fixes #2712
Tests | QA Steps
Tested On
Screenshots
Web
video-fail.mp4
Mobile Web
1622692926206.mp4
Desktop
iOS
Android
1622692141097.mp4