Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Permissions logic to fix IOU regression #3481

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Update Permissions logic to fix IOU regression #3481

merged 1 commit into from
Jun 9, 2021

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Jun 9, 2021 •
edited
Loading

CC @tgolen, @parasharrajat -- as your PRs had an unfortunate conflict

Details

Fixed Issues

Fixes #3401 (comment)

Tests

  • Send an IOU Request to a user with a USD personal policy currency
  • Login as the user with a USD personal policy currency
  • Attempt to open the IOU Details Modal
  • The IOU Details Modal should display

QA Steps

Run above test

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-06-09 at 15 31 21

Mobile Web

Simulator Screen Shot - iPhone 11 - 2021-06-09 at 16 08 00

Desktop

Screenshot 2021-06-09 at 16 12 21

iOS

Simulator Screen Shot - iPhone 11 - 2021-06-09 at 16 07 36

Android

Screenshot_1623252148

@Julesssss Julesssss requested a review from a team June 9, 2021 14:51
@Julesssss Julesssss self-assigned this Jun 9, 2021
@Julesssss Julesssss mentioned this pull request Jun 9, 2021
Merged
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team June 9, 2021 14:51
@Julesssss Julesssss marked this pull request as ready for review June 9, 2021 15:23
@Julesssss Julesssss requested a review from a team as a code owner June 9, 2021 15:23
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team June 9, 2021 15:23
@Julesssss
Copy link
Contributor Author

Ready for review @pecanoro. This is a deploy blocker for the N5 builds.

@parasharrajat parasharrajat mentioned this pull request Jun 9, 2021
Merged
5 tasks
roryabraham
roryabraham reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not trying to slow things down here, but imo we really shouldn't be using withOnyx for the betas key – we should just be using Onyx.connect directly in the permissions library. Using withOnyx will lead to unnecessary duplicate Onyx subscriptions. NAB but in my opinion something that should be cleaned up in a follow-up

@parasharrajat
Copy link
Member

@roryabraham, Actually we moved from that implemented to withOnyx one as beta checking was not in sync with components. Also, after Onyx cache implementation, multiple subscriptions do not hurt the app that much as data is only read once from the Cold Storage.

@Julesssss
Copy link
Contributor Author

Thanks for the thoughts all, I believe I'm simply applying a fix to a conflict between two PRs by following the pattern introduced here.

@Julesssss Julesssss mentioned this pull request Jun 9, 2021
Merged
5 tasks
@Julesssss
Copy link
Contributor Author

As mentioned here. Tim and Rajat made changes to the same file very close to each other, so neither noticed the conflict which occurred once they were both merged to main. This was pretty unavoidable

@roryabraham roryabraham merged commit 64f1307 into main Jun 9, 2021
@roryabraham roryabraham deleted the jules-iouFixPermissionsRegression branch June 9, 2021 17:30
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions bot pushed a commit that referenced this pull request Jun 9, 2021
@roryabraham
Merge pull request #3481 from Expensify/jules-iouFixPermissionsRegres…
9b26ab0 
…sion

Update Permissions logic to fix IOU regression

(cherry picked from commit 64f1307)
@OSBotify OSBotify mentioned this pull request Jun 9, 2021
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

🚀 Cherry-picked to staging in version: 1.0.66-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham mentioned this pull request Jun 10, 2021
Closed
49 tasks
@Julesssss Julesssss mentioned this pull request Jun 11, 2021
Merged
5 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jun 17, 2021
Closed
This was referenced Jun 25, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Jul 7, 2021
Closed
57 tasks
@isagoico
Copy link

isagoico commented Jul 8, 2021

Same situation here #3486 (comment) CC @roryabraham

This was referenced Jul 12, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham left review comments

@TomatoToaster TomatoToaster TomatoToaster approved these changes

@parasharrajat parasharrajat parasharrajat approved these changes

@pecanoro pecanoro Awaiting requested review from pecanoro

Assignees

@Julesssss Julesssss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Julesssss @parasharrajat @OSBotify @isagoico @TomatoToaster @roryabraham