[No QA] Improved permission checking

[parasharrajat]

Details

A details explanation can be found here #3194 (comment)

Fixed Issues

Fixes #3194

Tests

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Not sure what do I need to show.

[sketchydroide]

LGTM

[sketchydroide]

I think it looks good, but @parasharrajat can you fix travis please :)

[parasharrajat]

Not sure what happened but it seems actions are giving false errors. @sketchydroide Could you please apply recheck here?

[parasharrajat]

@sketchydroide Could you please rerun the actions? I checked it seems that the failing point does not exist in the code. Also if it looks good, we can talk about merging it. Thanks.

[sketchydroide]

I did, but let me try again, and I agree that this does not even seem to exist in the code, but that can mean it's somewhere else, I've had that happening to me. let us check, we can always revert is this breaks anything

[parasharrajat]

I recently noticed that checks are failing. Check this #3421.

[parasharrajat]

Do I need to do anything here?

[sketchydroide]

I don't think so

[OSBotify]

🚀 Deployed to staging in version: 1.0.65-11🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[trjExpensify]

Marking this as a deploy blocker, so it's correctly reflected here. Thanks @Julesssss for getting a PR up to fix the regression!

[Julesssss]

I think this is no longer a blocker now that we have CP'd the fix.

[OSBotify]

🚀 Deployed to production in version: 1.0.68-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅