Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed edited flag is shown for brief moment #3421

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 8, 2021

Details

Skip edit status for the unchanged messages.

Fixed Issues

Fixes #3219

Tests | QA Steps

  1. Navigate to a conversation in e.cash
  2. Click on edit comment on a message
  3. Press save without making any changes
  4. No Edited tag should be shown.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

edited-w.mp4

Mobile Web

1623151972630.mp4

Desktop

edited-d.mp4

iOS

Android

1623166897449.mp4

@parasharrajat parasharrajat marked this pull request as ready for review June 8, 2021 15:12
@parasharrajat parasharrajat requested a review from a team as a code owner June 8, 2021 15:12
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team June 8, 2021 15:12
@parasharrajat
Copy link
Member Author

@roryabraham It seems checks are failing.

@roryabraham
Copy link
Contributor

Merge main into your branch and try again.

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit 9054dc3 into Expensify:main Jun 8, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to staging in version: 1.0.65-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the edited branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants