Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - Currencies are not displayed after clicking the currency symbol for a second time #3482

Closed
isagoico opened this issue Jun 9, 2021 · 14 comments
Assignees

Comments

@isagoico
Copy link

isagoico commented Jun 9, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

List of currencies should display.

Actual Result:

An empty list is displayed.

Action Performed:

  1. Open e.cash and log in
  2. Navigate to a conversation
  3. Click on request money
  4. Click on the currency symbol
  5. Select a currency
  6. Click on the currency symbol.

Workaround:

Searching for the currency does show the results.

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android
Desktop App
Mobile Web

Version Number: 1.0.66-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @AndrewGable https://expensify.slack.com/archives/C01GTK53T8Q/p1623251127130300

On the second time you change the currency on an IOU the currency list is blank. e.g. click $ -> change to £ -> click £ -> List is empty

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Jun 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jun 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@trjExpensify
Copy link
Contributor

trjExpensify commented Jun 9, 2021

@yuwenmemon, I confirmed this isn't happening on production, so pretty sure it must be related to one of the PRs from yesterday's staging deploy here.

@kidroca
Copy link
Contributor

kidroca commented Jun 9, 2021

This will be resolved after Expensify/react-native-onyx#81 is merged and react-native-onyx updated

@yuwenmemon
Copy link
Contributor

Looks like it got merged!

@kidroca
Copy link
Contributor

kidroca commented Jun 9, 2021

We still need to update E.cash, will post a PR in a second

@yuwenmemon yuwenmemon assigned kidroca and unassigned yuwenmemon Jun 9, 2021
@yuwenmemon
Copy link
Contributor

Thanks @kidroca!

@Julesssss
Copy link
Contributor

Oh, I've got a bump PR here too @kidroca

@Julesssss
Copy link
Contributor

Nevermind, you've seen already 👍

@kidroca
Copy link
Contributor

kidroca commented Jun 10, 2021

@yuwenmemon
The merge request with a fix for this issue was merged by @Julesssss

@Julesssss
Copy link
Contributor

Removing the DeployBlocker label

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Jun 11, 2021
@kidroca
Copy link
Contributor

kidroca commented Jul 5, 2021

@isagoico @Julesssss
I'm not sure why this ticket is still open
I'm not working on anything related to Currencies

@isagoico
Copy link
Author

isagoico commented Jul 5, 2021

Not sure either. I just rechecked the issue in Web and it's not happening anymore. Closing the issue (@Julesssss please feel free to reopen if this issue was open for other reason)

@isagoico isagoico closed this as completed Jul 5, 2021
@Julesssss
Copy link
Contributor

Whoops, this was missed somehow. Thanks for updating it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants