Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-QA] Bump Onyx commit to fix IOU regression #3483

Merged
merged 2 commits into from
Jun 9, 2021
Merged

[NO-QA] Bump Onyx commit to fix IOU regression #3483

merged 2 commits into from
Jun 9, 2021

Conversation

Julesssss
Copy link
Contributor

CC @marcaaron

Details

Bumps Onyx after this regression fix PR

Fixed Issues

N/A

Tests

N/A -- the feature was tested here

QA Steps

N/A

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@Julesssss Julesssss requested a review from a team June 9, 2021 17:16
@Julesssss Julesssss self-assigned this Jun 9, 2021
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team June 9, 2021 17:16
@Julesssss Julesssss mentioned this pull request Jun 9, 2021
Closed
@marcaaron
Copy link
Contributor

eslint is failing (probably because it's broken on main - also... what? how?)

@Julesssss
Copy link
Contributor Author

Yeah, that's expected. The initial issue was triggered by an unlucky conflict. This lint exists on main currently. Fixing now.

@Julesssss
Copy link
Contributor Author

Here's the original explanation: #3401 (comment)

(I am getting confused with all these fixes)

@Julesssss
Copy link
Contributor Author

My PR here fixes the regression and the lint error: #3481

@Julesssss Julesssss requested a review from a team as a code owner June 9, 2021 17:32
@MelvinBot MelvinBot requested review from Gonals and removed request for a team June 9, 2021 17:32
@Julesssss
Copy link
Contributor Author

Julesssss commented Jun 9, 2021 •
edited
Loading

Okay. The PR which fixes a lint which slipped into main due to a conflict has been merged. I updated this PR, so the tests will pass this time.

@Julesssss
Copy link
Contributor Author

Ready for review: @sketchydroide @marcaaron

@alex-mechler alex-mechler merged commit 48e39fb into main Jun 9, 2021
@alex-mechler alex-mechler deleted the jules-bumpOnyxToFixRegression branch June 9, 2021 18:18
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions bot pushed a commit that referenced this pull request Jun 9, 2021
Merge pull request #3483 from Expensify/jules-bumpOnyxToFixRegression
c521094 
[NO-QA] Bump Onyx commit to fix IOU regression

(cherry picked from commit 48e39fb)
@OSBotify OSBotify mentioned this pull request Jun 9, 2021
Merged
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

🚀 Cherry-picked to staging in version: 1.0.66-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kidroca kidroca mentioned this pull request Jun 10, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham mentioned this pull request Jun 10, 2021
Closed
49 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jun 17, 2021
Closed
@OSBotify OSBotify mentioned this pull request Jun 25, 2021
Closed
72 tasks
@OSBotify OSBotify mentioned this pull request Jun 29, 2021
Closed
22 tasks
This was referenced Jul 7, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Jul 14, 2021
Closed
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-mechler alex-mechler alex-mechler approved these changes

@sketchydroide sketchydroide Awaiting requested review from sketchydroide

@Gonals Gonals Awaiting requested review from Gonals

Assignees

@Julesssss Julesssss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Julesssss @marcaaron @OSBotify @alex-mechler