Fix line breaks in homepage links #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisl
approved these changes
Jun 9, 2021
|
🚀 Deployed to staging in version: 1.0.66-13🚀
|
49 tasks
5 tasks
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roryabraham @arielgreen
Details
Fixed the line break after the privacy policy link and before licences links by putting them into a Text component. This change affects only web and mobile web.
Fixed Issues
Fixes #3100
Tests
Verified terms of service and privacy policy links are accessible via keyboard from Safari and Chrome on MacOS when VoiceOver is enabled.
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2021-06-10.at.00.11.55.mov