Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed
97 tasks done
OSBotify opened this issue Oct 12, 2023 · 25 comments
Closed
97 tasks done

Deploy Checklist: New Expensify 2023-10-12 #29417

OSBotify opened this issue Oct 12, 2023 · 25 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 12, 2023

Release Version: 1.3.83-11
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 12, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.83-0 🚀

@youssef-lr
Copy link
Contributor

Checked off #28710, cc @JKobrynski for the remaining issue

@mountiny
Copy link
Contributor

mountiny commented Oct 12, 2023

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@kavimuru
Copy link

Regression 63% progress. Validating few PRs.
#29202 failing with #29444
#29063 failing with #29444
#26219 failing with #29462 in offline

@jasperhuangg
Copy link
Contributor

#29202 failing with #29444
#29063 failing with #29444

#29444 is NAB so we can check them off

@jasperhuangg
Copy link
Contributor

Checking off #29462 cannot reproduce and testing steps unclear
Therefore checking off #26219 as well

@jasperhuangg
Copy link
Contributor

Checking off #29450, was fixed by #29412

@jasperhuangg
Copy link
Contributor

Checking off #29503

@jasperhuangg
Copy link
Contributor

Checking off #29494

@jasperhuangg
Copy link
Contributor

Checking off #29388, tested myself and works as expected

@mvtglobally
Copy link

Down to 12 % left

@jasperhuangg
Copy link
Contributor

Checking off #29452 and #29475
#29524 was CP'd which fixes them both

@jasperhuangg
Copy link
Contributor

Checking off #29492, fixed by #29525

@jasperhuangg
Copy link
Contributor

@mvtglobally I've resolved all the existing blockers, gonna sign off for a bit but I'll be back online later to check again.

@mvtglobally
Copy link

@jasperhuangg We will provide next update in the morning EST. We still have 10% to go

@jasperhuangg
Copy link
Contributor

@mvtglobally Gotcha, thanks for sticking with it! I'll be online first thing tomorrow to help deploy.

@kavimuru
Copy link

Regression TR is 3% left (working on last slot). We are validating the CP and couple iOS platform PRs

#29064 failing with #29495
#28399 failing with #27680 which is a known issue
#29070 failing with #29533

@mvtglobally
Copy link

mvtglobally commented Oct 13, 2023

Regression is completed @jasperhuangg

Open Blocker:
#29555

Unchecked PRs:
#29064 failing with #29495

#29070 failing with #29533, repro in PROD, checking off
#28399 failing with #27680, repro in PROD, checking off

@Julesssss
Copy link
Contributor

Checked off #29555 as it is too minor to block the release.

@mountiny
Copy link
Contributor

@mountiny
Copy link
Contributor

No new prevailing crashes and graphs looking good

@jasperhuangg
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants