Scan - Split bill - Empty merchant field does not show error message in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR #29064

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline
3. Go to + > Request money > Scan > Upload a receipt
4. Select Split on any user
5. Create the bill split
6. Click on the bill split preview
7. Click Split
8. Edit the fields with error message which are Amount and Date
9. Click Split

Expected Result:

In Step 7, Amount, Date and Merchant fields will show error message

Actual Result:

In Step 7, only Amount and Date fields show error message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6234911_1697139820173.20231013_033624.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018dcd4b4068835b24
• Upwork Job ID: 1712746926499971072
• Last Price Increase: 2023-10-13

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

Discussed here, not a blocker https://expensify.slack.com/archives/C01GTK53T8Q/p1697146393007749?thread_ts=1697144865.452089&cid=C01GTK53T8Q

Might be fixed by @youssef-lr PR

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018dcd4b4068835b24

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[youssef-lr]

Working on a clean up PR and will get this fixed there as well.

[trjExpensify]

Putting this one as high as the experience we're shooting for uses receipts, so merchants should be shown when scanned.

[youssef-lr]

This should be fixed now in main!

[CortneyOfstad]

@mountiny @youssef-lr are we good to close this, since the PR fixes this issue? TIA!

[youssef-lr]

Yup! But I'd wait until PR is deployed.

[youssef-lr]

We should be good now.