[HOLD for payment 2023-10-23][$125] Send money - Avatars and names overlap in Send money report details page #29439

lanitochka17 · 2023-10-12T13:24:40Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team/ @aman-atg

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697098677979179

Action Performed:

Go to staging.new.expensify.com
Go to + > Send money
Send money to any user
Click on the IOU preview to open report page
Click on the avatar on the header
Note that the avatars and names overlap in Send money details page

Expected Result:

The avatars and names do not overlap in Send money details page

Actual Result:

The avatars and names overlap in Send money details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6234355_1697113243739.20231012_194223.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bf850787ca824440
Upwork Job ID: 1712525329990500352
Last Price Increase: 2023-10-12
Automatic offers:

akinwale | Reviewer | 27165440
hungvu193 | Contributor | 27165444

melvin-bot · 2023-10-12T13:24:46Z

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-12T13:24:48Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

hungvu193 · 2023-10-12T13:40:52Z

~~Another regression from #28323~~

cc @Pujan92

Pujan92 · 2023-10-12T13:46:52Z

@hungvu193 It is not from my PR as it is also reproduced in the staging. My PR is not deployed to the staging yet.

aman-atg · 2023-10-12T13:50:13Z

I reported this here. Please update the reporter if my report was posted before the QA

cc: @kavimuru

hungvu193 · 2023-10-12T13:54:18Z

@hungvu193 It is not from my PR as it is also reproduced in the staging. My PR is not deployed to the staging yet.

My bad. I fixed the issue by reverting your changes 😂 . Agreed this is not regression from your PR.

hungvu193 · 2023-10-12T14:07:08Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatars and names overlap in Send money report details page.

What is the root cause of that problem?

We're using size={CONST.AVATAR_SIZE.LARGE} for our multiple avatar of Request Money here.

App/src/pages/ReportDetailsPage.js

Lines 168 to 170 in 2c9c303

    
           <MultipleAvatars 
        
               icons={icons} 
        
               size={CONST.AVATAR_SIZE.LARGE}

However we didn't have it here:

App/src/styles/StyleUtils.ts

Lines 1271 to 1286 in 2c9c303

    
           function getContainerStyles(size: string, isInReportAction = false): Array<ViewStyle | CSSProperties> { 
        
               let containerStyles: Array<ViewStyle | CSSProperties>; 
        
               switch (size) { 
        
                   case CONST.AVATAR_SIZE.SMALL: 
        
                       containerStyles = [styles.emptyAvatarSmall, styles.emptyAvatarMarginSmall]; 
        
                       break; 
        
                   case CONST.AVATAR_SIZE.SMALLER: 
        
                       containerStyles = [styles.emptyAvatarSmaller, styles.emptyAvatarMarginSmaller]; 
        
                       break; 
        
                   case CONST.AVATAR_SIZE.MEDIUM: 
        
                       containerStyles = [styles.emptyAvatarMedium, styles.emptyAvatarMargin]; 
        
                       break; 
        
                   default: 
        
                       containerStyles = [styles.emptyAvatar, isInReportAction ? styles.emptyAvatarMarginChat : styles.emptyAvatarMargin]; 
        
               }

It will lead to default case which didn't have the margin bottom which caused this issue.

What changes do you think we should make in order to solve the problem?

We should add the case for CONST.AVATAR_SIZE.LARGE in getContainerStyles as well, it should be:

function getContainerStyles(size: string, isInReportAction = false): Array<ViewStyle | CSSProperties> {
    let containerStyles: Array<ViewStyle | CSSProperties>;

    switch (size) {
        case CONST.AVATAR_SIZE.SMALL:
            containerStyles = [styles.emptyAvatarSmall, styles.emptyAvatarMarginSmall];
            break;
        case CONST.AVATAR_SIZE.SMALLER:
            containerStyles = [styles.emptyAvatarSmaller, styles.emptyAvatarMarginSmaller];
            break;
        case CONST.AVATAR_SIZE.MEDIUM:
            containerStyles = [styles.emptyAvatarMedium, styles.emptyAvatarMargin];
            break;
        case CONST.AVATAR_SIZE.LARGE:
            containerStyles = [styles.emptyAvatarLarge, styles.mb2, styles.mr2];
            break;
        default:
            containerStyles = [styles.emptyAvatar, isInReportAction ? styles.emptyAvatarMarginChat : styles.emptyAvatarMargin];
    }

    return containerStyles;
}

What alternative solutions did you explore? (Optional)

N/A

Pujan92 · 2023-10-12T14:38:50Z

I see it is added here cc: @fedirjh

Seems like a bad merge but not able to find out where it is missed 😅, would be great if someone helps what happened exactly in this history https://github.com/Expensify/App/commits/main/src/components/MultipleAvatars.js

A simple way to fix this is by adding those lines back here in this PR.

melvin-bot · 2023-10-12T17:47:13Z

Job added to Upwork: https://www.upwork.com/jobs/~01bf850787ca824440

melvin-bot · 2023-10-12T17:47:19Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

melvin-bot · 2023-10-12T17:47:45Z

Upwork job price has been updated to $125

akinwale · 2023-10-12T18:11:48Z

@hungvu193's proposal correctly identifies the source of the problem, and the recommended fix is straightforward.

🎀 👀 🎀 C+ reviewed.

melvin-bot · 2023-10-12T18:11:54Z

Triggered auto assignment to @joelbettner, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2023-10-16T21:25:57Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny] Determine if we should create a regression test for this bug.
[@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:51:19Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix: Send money - Avatars and names overlap in Send money report details page #29483

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:51:21Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny] Determine if we should create a regression test for this bug.
[@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

mountiny · 2023-10-16T22:00:34Z

Deploy blocker, regression was clear and we have raised it above, no need for the checklist or special regression test, only payment to the bug reporter

mountiny · 2023-10-23T15:46:36Z

@dylanexpensify ready for payment

melvin-bot · 2023-10-27T12:53:50Z

@mountiny, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

mountiny · 2023-10-28T13:14:16Z

Waiting for payment

dylanexpensify · 2023-10-30T09:32:46Z

on it now!

dylanexpensify · 2023-10-30T09:34:36Z

done

aman-atg · 2023-10-30T10:27:50Z

@dylanexpensify ~~Sorry but I'm not able to find the upwork job for this. Can you share the link with me?~~ Found the link in OP and applied on Upwork for the reporting bonus.

aman-atg · 2023-10-31T11:10:36Z

bump @dylanexpensify

@mountiny Will it be better to just add this reporting bonus into some other job like this one.

dylanexpensify · 2023-11-06T10:14:59Z

ah paying now!

dylanexpensify · 2023-11-06T10:15:42Z

offer sent @aman-atg!

aman-atg · 2023-11-06T22:11:25Z

Accepted the offer!

dylanexpensify · 2023-11-07T09:57:32Z

done!

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2023

melvin-bot bot assigned dylanexpensify Oct 12, 2023

m-natarajan mentioned this issue Oct 12, 2023

[$500] Avatars are not displaying properly and are appearing behind emails on the Details page. #29470

Closed

6 tasks

OSBotify mentioned this issue Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 12, 2023

melvin-bot bot changed the title ~~Send money - Avatars and names overlap in Send money report details page~~ [$500] Send money - Avatars and names overlap in Send money report details page Oct 12, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

melvin-bot bot assigned akinwale Oct 12, 2023

mountiny changed the title ~~[$500] Send money - Avatars and names overlap in Send money report details page~~ [$125] Send money - Avatars and names overlap in Send money report details page Oct 12, 2023

melvin-bot bot assigned joelbettner Oct 12, 2023

mountiny assigned hungvu193 and mountiny and unassigned joelbettner Oct 12, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 19, 2023

melvin-bot bot added Overdue and removed Overdue labels Oct 23, 2023

melvin-bot bot removed the Overdue label Oct 28, 2023

dylanexpensify closed this as completed Oct 30, 2023

mountiny reopened this Nov 1, 2023

melvin-bot bot added the Overdue label Nov 3, 2023

melvin-bot bot removed the Overdue label Nov 6, 2023

dylanexpensify closed this as completed Nov 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23][$125] Send money - Avatars and names overlap in Send money report details page #29439

[HOLD for payment 2023-10-23][$125] Send money - Avatars and names overlap in Send money report details page #29439

lanitochka17 commented Oct 12, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

hungvu193 commented Oct 12, 2023 •

edited

Loading

Pujan92 commented Oct 12, 2023 •

edited

Loading

aman-atg commented Oct 12, 2023

hungvu193 commented Oct 12, 2023

hungvu193 commented Oct 12, 2023

Pujan92 commented Oct 12, 2023 •

edited

Loading

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

akinwale commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

mountiny commented Oct 16, 2023

mountiny commented Oct 23, 2023

melvin-bot bot commented Oct 27, 2023

mountiny commented Oct 28, 2023

dylanexpensify commented Oct 30, 2023

dylanexpensify commented Oct 30, 2023

aman-atg commented Oct 30, 2023 •

edited

Loading

aman-atg commented Oct 31, 2023

dylanexpensify commented Nov 6, 2023

dylanexpensify commented Nov 6, 2023

aman-atg commented Nov 6, 2023

dylanexpensify commented Nov 7, 2023

[HOLD for payment 2023-10-23][$125] Send money - Avatars and names overlap in Send money report details page #29439

[HOLD for payment 2023-10-23][$125] Send money - Avatars and names overlap in Send money report details page #29439

Comments

lanitochka17 commented Oct 12, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

Bug0 Triage Checklist (Main S/O)

hungvu193 commented Oct 12, 2023 • edited Loading

Pujan92 commented Oct 12, 2023 • edited Loading

aman-atg commented Oct 12, 2023

hungvu193 commented Oct 12, 2023

hungvu193 commented Oct 12, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Pujan92 commented Oct 12, 2023 • edited Loading

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

akinwale commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

mountiny commented Oct 16, 2023

mountiny commented Oct 23, 2023

melvin-bot bot commented Oct 27, 2023

mountiny commented Oct 28, 2023

dylanexpensify commented Oct 30, 2023

dylanexpensify commented Oct 30, 2023

aman-atg commented Oct 30, 2023 • edited Loading

aman-atg commented Oct 31, 2023

dylanexpensify commented Nov 6, 2023

dylanexpensify commented Nov 6, 2023

aman-atg commented Nov 6, 2023

dylanexpensify commented Nov 7, 2023

lanitochka17 commented Oct 12, 2023 •

edited by melvin-bot bot

Loading

hungvu193 commented Oct 12, 2023 •

edited

Loading

Pujan92 commented Oct 12, 2023 •

edited

Loading

Pujan92 commented Oct 12, 2023 •

edited

Loading

aman-atg commented Oct 30, 2023 •

edited

Loading