-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Message Box Style Fixes #29059
Edit Message Box Style Fixes #29059
Conversation
We achieve this by moving the cross icon view inside the message edit view (where we apply compose box styles).
We achieve this by using styles.textInputComposeBorder on the message view.
We change the style of button to composerSizeButton (used by the attachment picker button)
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromemweb.chrome.movMobile Web - Safarimweb.safari.moviOSios.movAndroidmweb.chrome.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
@luacmartins all yours! |
@shawnborton wanna review this PR since it's mostly a style change? |
@thienlnam I thought adding the Design label added a Designer as a reviewer? |
Nice, this looks pretty good to me! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
we're ignoring e2e tests for now - https://expensify.slack.com/archives/C05LX9D6E07/p1696530579819499 |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.81-0 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.83-0 🚀
|
Details
Fixed Issues
$ #28663
PROPOSAL: #28663 (comment)
Tests
Edit Message
option.Offline tests
Edit Message
option.QA Steps
Edit Message
option.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Edit.Message.Style.Similar.to.Composer.webm
Mobile Web - Chrome
video6129496622968605468.mp4
Mobile Web - Safari
Screencast.webm
Desktop
Edit.Message.Desktop.webm
iOS
ReportMessageEdit.webm
Android
MessageEditStyleAndroid.webm