Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Message Box Style Fixes #29059

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

neonbhai
Copy link
Contributor

@neonbhai neonbhai commented Oct 7, 2023

Details

Fixed Issues

$ #28663
PROPOSAL: #28663 (comment)

Tests

  1. Login to expensify, and to a non archived chat.
  2. Edit a message, by hovering on it and clicking on Edit Message option.
  3. Verify that the edit message box looks similar to new message box in the bottom.
  4. Verify that the cross icon is inside the edit message box.
  • Verify that no errors appear in the JS console

Offline tests

  1. Login to expensify, and to a non archived chat.
  2. Edit a message, by hovering on it and clicking on Edit Message option.
  3. Verify that the edit message box looks similar to new message box in the bottom.
  4. Verify that the cross icon is inside the edit message box.
  • Verify that no errors appear in the JS console

QA Steps

  1. Login to expensify, and to a non archived chat.
  2. Edit a message, by hovering on it and clicking on Edit Message option.
  3. Verify that the edit message box looks similar to new message box in the bottom.
  4. Verify that the cross icon is inside the edit message box.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Edit.Message.Style.Similar.to.Composer.webm
Mobile Web - Chrome
video6129496622968605468.mp4
Mobile Web - Safari

Screencast.webm

Desktop
Edit.Message.Desktop.webm
iOS

ReportMessageEdit.webm

Android

MessageEditStyleAndroid.webm

We achieve this by moving the cross icon view inside the message edit view (where we apply compose box styles).
We achieve this by using styles.textInputComposeBorder on the message view.
We change the style of button to composerSizeButton (used by the attachment picker button)
@neonbhai neonbhai requested a review from a team as a code owner October 7, 2023 23:27
@melvin-bot melvin-bot bot removed the request for review from a team October 7, 2023 23:27
@melvin-bot
Copy link

melvin-bot bot commented Oct 7, 2023

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from ArekChr October 7, 2023 23:27
@ArekChr
Copy link
Contributor

ArekChr commented Oct 9, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
mweb.chrome.mov
Mobile Web - Safari
mweb.safari.mov
Desktop desktop1 desktop2
iOS
ios.mov
Android
mweb.chrome.mov

Copy link
Contributor

@ArekChr ArekChr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@melvin-bot melvin-bot bot requested a review from luacmartins October 9, 2023 10:13
@neonbhai
Copy link
Contributor Author

neonbhai commented Oct 9, 2023

@luacmartins all yours!

@luacmartins
Copy link
Contributor

@shawnborton wanna review this PR since it's mostly a style change?

@shawnborton
Copy link
Contributor

@thienlnam I thought adding the Design label added a Designer as a reviewer?

@shawnborton
Copy link
Contributor

Nice, this looks pretty good to me!

@luacmartins luacmartins merged commit 708794c into Expensify:main Oct 10, 2023
15 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 10, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1342.565 ms → 1516.066 ms (+173.501 ms, +12.9%) 🔴
App start runJsBundle 935.389 ms → 1034.333 ms (+98.944 ms, +10.6%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1342.565 ms
Stdev: 54.508 ms (4.1%)
Runs: 1231.3688509999774 1231.5850530001335 1237.6611629999243 1239.3401270001195 1243.7409740001895 1250.0726689998992 1262.6788209998049 1263.9013359998353 1263.923169999849 1264.919393000193 1269.3702859999612 1270.0202770000324 1275.4239849997684 1285.9000639999285 1286.6908490001224 1289.4228190002032 1290.4910690002143 1293.580101000145 1293.6069370000623 1296.3976159999147 1303.179241000209 1308.098805999849 1314.065942000132 1314.9489259999245 1315.1068339999765 1315.3800010001287 1319.054188999813 1323.8801009999588 1324.7759949997999 1325.7043030001223 1325.9619729998522 1326.8815489998087 1327.39930499997 1327.6517210002057 1330.1303650001064 1331.1287170001306 1331.8277369998395 1333.2680020001717 1333.721603000071 1334.418295999989 1336.0425260001794 1338.91256600013 1339.8454909999855 1340.1331949997693 1340.8013760000467 1342.7788900001906 1344.5311940000392 1345.4343159999698 1347.8117010002024 1349.9264210001566 1350.5397720001638 1350.8521179999225 1354.2349209999666 1355.6655140002258 1357.356742999982 1357.3610609997995 1359.2632760000415 1360.0696029998362 1364.1242060000077 1364.410118999891 1365.1683149999008 1366.0657709999941 1369.1577249998227 1371.4273950001225 1373.1321279997937 1373.2009530002251 1376.9205390000716 1379.1518040001392 1382.2045109998435 1387.213907000143 1387.8847289998084 1388.0531370001845 1390.7859530001879 1393.4677929999307 1394.8485840000212 1394.8701289999299 1408.886111999862 1410.1859100000001 1411.3643609997816 1412.6396099999547 1413.7526259999722 1422.9357090000995 1425.6056809998117 1426.802507000044 1434.3328109998256 1437.9821020001546 1446.7615100000985 1455.4569640001282 1481.2762380000204

Current
Mean: 1516.066 ms
Stdev: 79.902 ms (5.3%)
Runs: 1343.994320999831 1345.6725599998608 1347.1021650000475 1352.0424750000238 1363.579067000188 1373.6619060002267 1378.5757849998772 1387.7700959998183 1394.6222769999877 1398.2594159999862 1402.8386550000869 1412.6042260001414 1414.675054000225 1417.4335489999503 1426.9796870001592 1432.7846019999124 1438.5624549998902 1441.742072999943 1450.5593059998937 1454.5331839998253 1457.239486000035 1461.1557169998996 1465.9203499997966 1466.9387440001592 1472.8711430002004 1475.3294429997914 1476.417919000145 1480.214341999963 1483.8529889998026 1493.651786999777 1495.77155999979 1497.5170660000294 1497.640327999834 1497.680391000118 1499.6711840000935 1501.7827380001545 1502.2816019998863 1505.9820139999501 1508.477295000106 1509.4084459999576 1514.3413189998828 1514.4504370000213 1518.653028999921 1521.2440450000577 1521.7998879998922 1522.125494999811 1522.263222000096 1527.4787739999592 1531.533303000033 1532.0869450001046 1533.5274660000578 1537.2636239998974 1537.8369169998914 1539.9990590000525 1540.4653690000996 1547.0918689998798 1547.77556299977 1548.7658790000714 1550.8530109999701 1553.3118070000783 1559.359383000061 1559.5914830002002 1561.0449810000136 1563.4062299998477 1564.6204249998555 1567.380200999789 1569.8178159999661 1573.01253500022 1575.270235999953 1576.5417920001782 1579.4359510000795 1581.9303109999746 1583.0869029997848 1583.1376009997912 1585.908187000081 1587.8184549999423 1588.1816630000249 1591.7459780001082 1596.6161349997856 1600.4939419999719 1603.9469170002267 1614.155505000148 1615.953561999835 1627.7369499998167 1630.4667239999399 1631.0077329999767 1633.3089230000041 1637.9178619999439 1650.341744999867 1681.5856920001097 1696.5467500002123
App start runJsBundle Baseline
Mean: 935.389 ms
Stdev: 44.813 ms (4.8%)
Runs: 819 845 846 851 859 861 863 868 869 869 872 873 879 887 892 893 896 898 900 902 905 906 906 908 913 914 915 918 918 920 921 923 923 923 929 929 930 930 930 931 931 936 938 938 939 940 940 941 943 944 946 947 947 948 949 950 950 950 951 953 953 956 956 959 961 964 964 965 965 967 969 970 971 971 972 976 976 979 981 986 991 992 997 999 1005 1014 1015 1020 1025 1051

Current
Mean: 1034.333 ms
Stdev: 49.239 ms (4.8%)
Runs: 927 931 935 937 940 943 944 946 950 950 960 961 962 964 975 987 996 997 1009 1009 1009 1011 1012 1014 1016 1018 1019 1020 1021 1022 1022 1023 1024 1026 1034 1036 1036 1036 1037 1040 1042 1044 1044 1045 1045 1046 1047 1048 1048 1049 1050 1050 1051 1052 1053 1055 1056 1056 1056 1057 1059 1061 1061 1062 1064 1064 1065 1066 1069 1070 1071 1075 1080 1083 1085 1085 1086 1086 1092 1096 1103 1106 1108 1115 1121 1126 1135

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 665.827 ms → 685.796 ms (+19.970 ms, +3.0%)
App start nativeLaunch 21.955 ms → 24.955 ms (+3.001 ms, +13.7%)
App start regularAppStart 0.016 ms → 0.019 ms (+0.002 ms, +12.9%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 665.827 ms
Stdev: 29.040 ms (4.4%)
Runs: 603.972779000178 619.0994059997611 619.7003179998137 620.5046799997799 620.9908039998263 622.5022380002774 628.6924640000798 629.7557379999198 630.4274909999222 632.537434999831 634.5925289997831 635.3369950000197 636.8845220003277 636.9910079999827 639.062947999686 641.391114000231 641.5194089999422 643.2183019998483 643.5819089999422 645.1698409998789 646.1478689997457 646.1616619997658 646.4962570001371 647.5006110002287 648.1922209998593 648.9663089998066 649.0563560002483 649.7199710002169 649.815673999954 650.0333259999752 650.3146969997324 650.3824060000479 650.422038000077 651.541300999932 652.8258870001882 652.9674480003305 653.3919680002145 653.4978439998813 655.5088709997945 655.5636809999123 656.6317549999803 657.1845709998161 658.2919519999996 659.1072189998813 659.7256680000573 660.8589280000888 661.5598960001953 662.2926839999855 662.8743090000935 663.1682130000554 663.9920649998821 666.4776209997945 666.9803880001418 667.8275150000118 667.8364659999497 668.1014819997363 668.5594489998184 668.6166179999709 668.6766769997776 670.7701010000892 673.2671719999053 673.9715990000404 674.8966879998334 675.1877040001564 676.2781179999001 676.6508380002342 678.8780529997312 683.7742510000244 684.6434330004267 685.3954270002432 687.3642990002409 689.92240400007 694.3616949999705 697.3216550000943 699.7470700000413 699.933960000053 700.2294109999202 700.9176429999061 700.9240319998935 704.8421229999512 705.5325110000558 706.3382570003159 714.2889410001226 715.2078859996982 717.4615480001085 717.5952150002122 720.0528159998357 722.9474289999343 725.3109129997902 726.1958419997245 746.8144530002028

Current
Mean: 685.796 ms
Stdev: 28.087 ms (4.1%)
Runs: 638.9954829998314 646.2070720000193 650.9571940000169 651.7860920000821 654.2164309993386 655.7629390000366 656.3417969997972 658.1867680000141 658.6394859999418 659.3404540000483 660.2156170001253 660.328572999686 661.1762289991602 661.9687100001611 661.9994299998507 662.447998999618 662.6542159998789 662.7952479999512 662.8642580001615 662.9071860001422 665.6242279997095 665.7497160001658 665.8891199999489 666.5748290000483 667.3132329997607 668.3697509998456 668.6711030001752 668.7507330002263 668.7685549999587 669.0101319998503 669.1814379999414 669.1844900003634 669.3537610000931 669.9385580001399 670.6889239996672 671.500041000545 672.226197000593 672.6669109994546 672.9812420001253 673.1985270003788 674.0227870000526 675.9686689991504 675.9824220002629 676.2482099998742 676.4901939998381 676.8702799999155 676.9001879999414 677.078125 677.5808520000428 677.875284999609 678.1080740001053 678.4961749995127 679.2635509995744 679.3432620000094 680.346476000268 683.2801109999418 683.4286700002849 683.6481530000456 688.7196860001422 689.2085369997658 689.3425289997831 690.0312909996137 690.6848960001953 690.7482099998742 690.8083910001442 692.8554279999807 697.5071209999733 701.0234380001202 701.3416339997202 701.8380950000137 703.5489509999752 703.6748049999587 711.7125249998644 711.997110999655 716.007040000055 716.4606119999662 716.6789560001343 721.7824309999123 728.0989589998499 728.6623939997517 729.6862389994785 731.3219000003301 732.2896739998832 735.3670660001226 740.9552000002004 749.0030519999564 749.6390789998695 750.3256029998884 753.0417479998432 753.1686610002071 753.5711269997992
App start nativeLaunch Baseline
Mean: 21.955 ms
Stdev: 2.742 ms (12.5%)
Runs: 18 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 25 25 25 25 26 26 27 27 27 27 27 27 27 29 30 30

Current
Mean: 24.955 ms
Stdev: 2.788 ms (11.2%)
Runs: 20 21 21 21 21 21 21 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 24 24 24 24 24 25 25 25 25 25 25 25 25 25 25 25 25 25 25 25 25 25 26 26 26 26 26 26 26 27 27 27 27 27 27 28 28 28 28 29 29 29 29 30 30 31 31 32 33 33
App start regularAppStart Baseline
Mean: 0.016 ms
Stdev: 0.001 ms (8.3%)
Runs: 0.013306000269949436 0.013712999876588583 0.013875000178813934 0.01444500032812357 0.014525999780744314 0.014527000021189451 0.014566999860107899 0.014607999939471483 0.014851999934762716 0.014892000239342451 0.015055999625474215 0.015217999927699566 0.01525900000706315 0.01525900000706315 0.015299999620765448 0.015420999843627214 0.015421000309288502 0.015422000084072351 0.015503000002354383 0.015542999841272831 0.015543000306934118 0.015544000081717968 0.015583999920636415 0.015625 0.015665999613702297 0.015666000079363585 0.015666000079363585 0.015705999918282032 0.015746999997645617 0.015746999997645617 0.015746999997645617 0.015787999611347914 0.0157880000770092 0.015829000156372786 0.015868999995291233 0.015868999995291233 0.015951000154018402 0.016031999606639147 0.016032000072300434 0.016032000072300434 0.016032000072300434 0.01607299968600273 0.016112999990582466 0.01615400006994605 0.016195000149309635 0.016195000149309635 0.016234999988228083 0.01623600022867322 0.016276000067591667 0.016315999906510115 0.016316999681293964 0.016398000065237284 0.016398000065237284 0.016439000144600868 0.016478999983519316 0.0165200000628829 0.01652099983766675 0.016561000142246485 0.016600999981164932 0.016600999981164932 0.016764000058174133 0.016764000058174133 0.01680499967187643 0.01688600005581975 0.016927000135183334 0.01696800021454692 0.017009000293910503 0.017171000130474567 0.017171000130474567 0.01733399974182248 0.0176189998164773 0.017740999814122915 0.017862999811768532 0.01794400019571185 0.018188000191003084 0.018188999965786934 0.01831099996343255 0.01831099996343255 0.018391999881714582 0.018432999961078167 0.01847400004044175 0.018554999958723783 0.01859500026330352 0.018717999570071697 0.019164999946951866 0.019286999944597483 0.019450000021606684 0.019450000021606684 0.019776000175625086

Current
Mean: 0.019 ms
Stdev: 0.001 ms (4.5%)
Runs: 0.016560999676585197 0.01660200022161007 0.01672299997881055 0.0167239997535944 0.016805999912321568 0.016846000216901302 0.016966999974101782 0.017089999746531248 0.017089999746531248 0.017130999825894833 0.017172000370919704 0.017578000202775 0.017740999814122915 0.017782000359147787 0.01794400019571185 0.01794400019571185 0.0179449999704957 0.01798499980941415 0.018025000113993883 0.01802600035443902 0.01806599972769618 0.018066000193357468 0.018106999807059765 0.018106999807059765 0.018108000047504902 0.01814799988642335 0.01814799988642335 0.018187999725341797 0.018269999884068966 0.018309999722987413 0.01831099996343255 0.018352000042796135 0.018391999881714582 0.018432000186294317 0.018432999961078167 0.018473000265657902 0.018514000345021486 0.018554999958723783 0.01859499979764223 0.01859500026330352 0.018596000038087368 0.018635999877005816 0.018635999877005816 0.018635999877005816 0.018636000342667103 0.018716999795287848 0.018717999570071697 0.018798000179231167 0.0188400000333786 0.0188400000333786 0.018881000112742186 0.01892100041732192 0.019001999869942665 0.019003000110387802 0.0190420001745224 0.01904299994930625 0.01904299994930625 0.01904299994930625 0.019083000253885984 0.019084000028669834 0.019084000028669834 0.019084000028669834 0.019084000028669834 0.01912400033324957 0.019164999946951866 0.019164999946951866 0.019164999946951866 0.019165000412613153 0.019204999785870314 0.019205999560654163 0.01920600002631545 0.019247000105679035 0.01928700041025877 0.019328000023961067 0.019448999781161547 0.019450000021606684 0.019530999939888716 0.019531000405550003 0.0195720000192523 0.019612999632954597 0.01965400017797947 0.019694000016897917 0.019857000093907118 0.019938999786973 0.02010100008919835

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@luacmartins
Copy link
Contributor

we're ignoring e2e tests for now - https://expensify.slack.com/archives/C05LX9D6E07/p1696530579819499

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.81-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.83-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants