Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Message Box Style Fixes #29059

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Edit Message Box Style Fixes #29059

merged 5 commits into from
Oct 10, 2023

Commits on Oct 7, 2023

  1. Move cross Icon inside the message input box 

    We achieve this by moving the cross icon view inside the message edit view (where we apply compose box styles).
    @neonbhai
    neonbhai committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    12bba91 View commit details
    Browse the repository at this point in the history

  2. Add border between button and message text 

    We achieve this by using styles.textInputComposeBorder on the message view.
    @neonbhai
    neonbhai committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    c97a69e View commit details
    Browse the repository at this point in the history

  3. Make Cross button shorter, to resemble plus button on main composer. 

    We change the style of button to composerSizeButton (used by the attachment picker button)
    @neonbhai
    neonbhai committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    492c231 View commit details
    Browse the repository at this point in the history

  4. Removing hover and press styles to align with the original composer s… 

    …tyles
    @neonbhai
    neonbhai committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9a289eb View commit details
    Browse the repository at this point in the history

  5. Remove unused imports.

    @neonbhai
    neonbhai committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    20b369b View commit details
    Browse the repository at this point in the history