Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$125] Split bill - Split Bill description on Details page is empty in Group chat #29496

Closed
2 of 6 tasks
lanitochka17 opened this issue Oct 12, 2023 · 22 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.83-5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Open New Expensify app
  2. Click the + icon in a Group conversation > Split Bill
  3. Select Split on any user > Next
  4. Enter description, date and merchant
  5. Create the bill split
  6. Click on the bill split preview

Expected Result:

Description should be saved and visible

Actual Result:

Description field is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Bug6234948_1697141202004.az_recorder_20231012_204939.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b2dd27f3e4c1c58d
  • Upwork Job ID: 1712586612101890048
  • Last Price Increase: 2023-10-19
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

discussed here, removing the blocker and exporting this

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 12, 2023
@melvin-bot melvin-bot bot changed the title Split bill - Split Bill description on Details page is empty in Group chat [$500] Split bill - Split Bill description on Details page is empty in Group chat Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b2dd27f3e4c1c58d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@mountiny mountiny changed the title [$500] Split bill - Split Bill description on Details page is empty in Group chat [$125] Split bill - Split Bill description on Details page is empty in Group chat Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Upwork job price has been updated to $125

@bernhardoj
Copy link
Contributor

Regression from #29055

@trjExpensify
Copy link
Contributor

@jeet-dhandha can you look into this regression from your PR please?

@jeet-dhandha
Copy link
Contributor

@bernhardoj Please share a video with the PR’s code and a video after reverting the code. As then only i can be sure its a regression from my PR. And also do check that the bugs fixed in the PR are also not coming back.if they are then the regression loop will go on forever.

Thanks in advance.

@bernhardoj
Copy link
Contributor

I don't have my laptop with me right now, but before #29055 you made a platform specific file for the MenuItem RenderHTML where the native file doesn't have the View wrapper.

<View style={styles.renderHTMLTitle}>
<RenderHTML html={getProcessedTitle} />
</View>

You also did explain here that wrapping the RenderHTML with View on native will make the text empty.

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@bondydaa, @maddylewis, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@bondydaa
Copy link
Contributor

@bernhardoj @jeet-dhandha what's the status here?

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2023
@jeet-dhandha
Copy link
Contributor

I am OOO this and next week due to health reasons.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@trjExpensify
Copy link
Contributor

Has this been tested or is it an Android only bug or something? 😕 I can't reproduce on desktop, web or iOS native:

IMG_0656 2

@melvin-bot melvin-bot bot added the Overdue label Oct 20, 2023
@maddylewis
Copy link
Contributor

@situchan - have you been able to reproduce this bug recently?

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@situchan
Copy link
Contributor

I am not able to reproduce on latest main

@trjExpensify
Copy link
Contributor

Confirming you tested on Android native?

@situchan
Copy link
Contributor

Tested android as well.

@bondydaa
Copy link
Contributor

going to close this out then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

9 participants