Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show proper avatar and display name when hovering #29146

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

dukenv0307
Copy link
Contributor

@dukenv0307 dukenv0307 commented Oct 10, 2023

Details

Show proper avatar and display name when hovering tooltip

Fixed Issues

$ #28626
PROPOSAL: #28626 (comment)

Tests

  1. Open the app
  2. Click on plus and click on assign task
  3. Enter any title and go to next step
  4. Assign the task to user with avatar and display name set and complete the assign task process
  5. Hover on @ user in task message
  6. Verify that the correct avatar and display name are displayed
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Open the app
  2. Click on plus and click on assign task
  3. Enter any title and go to next step
  4. Assign the task to user with avatar and display name set and complete the assign task process
  5. Hover on @ user in task message
  6. Verify that the correct avatar and display name are displayed
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome

1696915660236

iOS: Native
ios.1.mp4
iOS: mWeb Safari
safari.mov
MacOS: Chrome / Safari
web.5.mp4
MacOS: Desktop
desktop.4.mp4

@dukenv0307 dukenv0307 marked this pull request as ready for review October 10, 2023 06:47
@dukenv0307 dukenv0307 requested a review from a team as a code owner October 10, 2023 06:47
@melvin-bot melvin-bot bot requested review from ArekChr and removed request for a team October 10, 2023 06:47
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@ArekChr
Copy link
Contributor

ArekChr commented Oct 10, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web web
Mobile Web - Chrome
mweb.chrome.mov
Mobile Web - Safari
mweb.safari.mov
Desktop desktop
iOS
ios.mov
Android
android.mov

@melvin-bot melvin-bot bot requested a review from puneetlath October 10, 2023 11:16
@puneetlath puneetlath merged commit 14ef765 into Expensify:main Oct 10, 2023
16 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 10, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1181.563 ms → 1265.691 ms (+84.128 ms, +7.1%) 🔴
App start runJsBundle 801.554 ms → 870.165 ms (+68.610 ms, +8.6%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1181.563 ms
Stdev: 47.524 ms (4.0%)
Runs: 1075.599379999563 1080.4947100002319 1082.2574489992112 1094.4461950007826 1096.4561720006168 1104.1890779994428 1109.611571000889 1113.9725219998509 1116.0808370001614 1117.8473470006138 1121.1261500008404 1123.77670600079 1126.0851659998298 1126.8256780002266 1128.778317000717 1131.2629850003868 1135.61960599944 1138.8319060001522 1141.0177040006965 1141.474489999935 1144.4110909998417 1144.5633610002697 1146.9506119992584 1149.43895399943 1149.5559500008821 1149.577359000221 1150.0099209994078 1153.4353759996593 1154.4709859993309 1155.2449110001326 1159.1634170003235 1161.4783960003406 1161.6640920005739 1162.0439079999924 1162.7326660007238 1166.0954229999334 1170.8599989991635 1171.2679239995778 1172.7523389998823 1177.041696999222 1177.111726000905 1178.1490400005132 1180.3216260001063 1181.1030119992793 1182.6178740002215 1183.590218000114 1185.0520539991558 1186.8086939994246 1188.1950700003654 1192.3003560006618 1192.9399769995362 1194.3561470005661 1195.863580999896 1196.040054999292 1198.1892349999398 1198.2829519994557 1198.7057390008122 1199.258063999936 1199.4533380009234 1202.3328660000116 1204.693795999512 1205.6944869998842 1205.941780000925 1207.3278769999743 1207.8185360003263 1208.405053999275 1209.5291980002075 1210.3627659995109 1213.9043719992042 1214.2802729997784 1218.14910300076 1220.3986319992691 1221.9851539991796 1223.4914950001985 1224.256242999807 1225.713228000328 1228.1323140002787 1236.9782149996608 1239.9466740004718 1241.0495420005172 1242.5169479995966 1243.7695250008255 1244.7208229992539 1247.9967320002615 1248.0267009995878 1248.837222000584 1252.381190000102 1252.565929999575 1252.969084000215 1257.3649770002812 1270.458709999919 1294.9764029998332

Current
Mean: 1265.691 ms
Stdev: 44.561 ms (3.5%)
Runs: 1166.677385000512 1180.0336000006646 1183.329443000257 1188.5731540005654 1188.7537750005722 1199.2557960003614 1204.7031440008432 1210.0011010002345 1211.1523410007358 1213.9802170004696 1214.1679229997098 1215.0113420002162 1216.6085279993713 1216.6992400009185 1217.2086149994284 1217.3121630009264 1217.7076399996877 1219.4982309993356 1220.7352939993143 1220.866764999926 1221.2570939995348 1222.0224079992622 1231.0442260000855 1232.6900350004435 1233.1773230005056 1235.2886779997498 1239.7207629997283 1240.4316339995712 1240.9212219994515 1241.5420769993216 1242.8020070008934 1244.719062000513 1246.5129099991173 1250.7185859996825 1252.2896309997886 1253.5887129995972 1254.3728560004383 1254.3855119999498 1255.6917889993638 1257.7902300003916 1258.7348129991442 1258.8909690007567 1258.990932000801 1265.4077119994909 1266.1465590000153 1266.8699290007353 1272.5129799991846 1275.253031000495 1276.894115999341 1279.3031629994512 1279.8097430001944 1279.9905060008168 1280.4542950000614 1281.154588000849 1281.252208000049 1282.5179699994624 1284.2787790000439 1286.3318540006876 1286.7358410004526 1288.5096680000424 1289.3758439999074 1290.193220000714 1290.3335779998451 1292.2615099996328 1292.5658989995718 1292.8416889999062 1297.9910279996693 1299.9755940008909 1300.202563000843 1300.8082779999822 1301.4450320005417 1303.309205999598 1303.5856410004199 1303.7198760006577 1309.66801699996 1309.8193909991533 1311.355434000492 1312.2444989997894 1312.8554040007293 1316.7331089992076 1316.8246759995818 1318.191808000207 1327.6721780002117 1328.6134440004826 1330.8314050007612 1337.1537929996848 1337.8508790004998 1354.8276560008526 1358.2730940002948 1387.3855830002576
App start runJsBundle Baseline
Mean: 801.554 ms
Stdev: 37.123 ms (4.6%)
Runs: 715 724 727 729 732 734 735 738 753 757 757 757 758 759 759 762 763 764 767 769 769 769 770 775 778 780 780 783 784 784 786 787 794 795 795 798 799 799 799 800 801 805 806 806 808 808 808 810 810 810 810 810 814 814 815 815 816 816 818 818 818 820 820 821 822 823 823 824 825 826 828 831 831 831 832 832 833 834 836 839 841 841 842 844 850 854 857 862 863 866 878 895

Current
Mean: 870.165 ms
Stdev: 35.149 ms (4.0%)
Runs: 805 809 814 814 817 818 821 827 827 828 829 830 830 834 834 834 835 837 837 839 839 840 842 844 845 845 846 848 849 851 852 852 853 853 855 855 856 857 859 859 861 866 867 869 870 872 872 874 874 874 875 877 877 878 878 878 878 879 881 882 884 887 888 889 890 890 891 895 895 895 896 897 898 900 902 902 904 904 904 907 916 917 918 918 920 928 931 933 952 965 968

Meaningless Changes To Duration

Show entries
Name Duration
App start nativeLaunch 21.811 ms → 22.283 ms (+0.471 ms, +2.2%)
App start regularAppStart 0.015 ms → 0.015 ms (+0.000 ms, +1.7%)
Open Search Page TTI 621.571 ms → 620.014 ms (-1.557 ms, ±0.0%)
Show details
Name Duration
App start nativeLaunch Baseline
Mean: 21.811 ms
Stdev: 2.932 ms (13.4%)
Runs: 18 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 23 23 23 23 24 24 24 24 24 25 25 25 25 26 26 26 26 27 27 28 28 28 28 29 30 30

Current
Mean: 22.283 ms
Stdev: 2.965 ms (13.3%)
Runs: 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 24 24 24 24 25 25 25 25 25 25 26 26 26 26 27 27 27 28 29 29 30 30 30 30
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (6.6%)
Runs: 0.012248000130057335 0.012328999117016792 0.012329000979661942 0.012613998726010323 0.012614000588655472 0.012654000893235207 0.013062000274658203 0.013183001428842545 0.013183001428842545 0.013345999643206596 0.013346001505851746 0.013467999175190926 0.013508999720215797 0.013509999960660934 0.01355000026524067 0.013630999252200127 0.01371300034224987 0.013753000646829605 0.013793999329209328 0.013875000178813934 0.013875000178813934 0.013875000178813934 0.013875000178813934 0.013916000723838806 0.013955999165773392 0.013956999406218529 0.014037998393177986 0.014038000255823135 0.014077998697757721 0.014078998938202858 0.014118999242782593 0.014119001105427742 0.014201000332832336 0.014201000332832336 0.014242000877857208 0.0143630001693964 0.0143630001693964 0.014364000409841537 0.01440499909222126 0.014444999396800995 0.014485999941825867 0.014485999941825867 0.014527000486850739 0.014567000791430473 0.014607001096010208 0.014607999473810196 0.014607999473810196 0.014648998156189919 0.014649000018835068 0.014649000018835068 0.014689000323414803 0.014689000323414803 0.014728998765349388 0.014729000627994537 0.01477000117301941 0.014810999855399132 0.014812000095844269 0.014892999082803726 0.014892999082803726 0.014933999627828598 0.014933999627828598 0.014973999932408333 0.014973999932408333 0.014973999932408333 0.015015000477433205 0.015056001022458076 0.015096001327037811 0.015137000009417534 0.015177000313997269 0.015258999541401863 0.015298999845981598 0.01533999852836132 0.015381000936031342 0.015421001240611076 0.015421999618411064 0.015422001481056213 0.015502998605370522 0.01550300046801567 0.015543999150395393 0.015584999695420265 0.015584999695420265 0.015625 0.015786999836564064 0.01591000147163868 0.015991000458598137 0.01603199914097786 0.016356999054551125 0.016357000917196274 0.016397999599575996 0.016641998663544655

Current
Mean: 0.015 ms
Stdev: 0.001 ms (6.2%)
Runs: 0.013183999806642532 0.013183999806642532 0.01326499879360199 0.013345999643206596 0.013346001505851746 0.013467999175190926 0.013468999415636063 0.013591000810265541 0.013630999252200127 0.013671999797224998 0.01371300034224987 0.01371300034224987 0.013833999633789062 0.0138349998742342 0.0138349998742342 0.0138349998742342 0.013875000178813934 0.013875000178813934 0.013875000178813934 0.013875000178813934 0.013915998861193657 0.013916000723838806 0.013955999165773392 0.013956999406218529 0.013957001268863678 0.013996999710798264 0.014038000255823135 0.014077998697757721 0.014118999242782593 0.014118999242782593 0.014119001105427742 0.01411999948322773 0.014281999319791794 0.014282001182436943 0.014322999864816666 0.014403998851776123 0.014444999396800995 0.014444999396800995 0.014526000246405602 0.014566998928785324 0.014567000791430473 0.014606999233365059 0.014649000018835068 0.014689000323414803 0.014729000627994537 0.014770999550819397 0.014770999550819397 0.014852000400424004 0.014852000400424004 0.014932999387383461 0.014932999387383461 0.014932999387383461 0.014933999627828598 0.014973999932408333 0.015013998374342918 0.015015000477433205 0.015055999159812927 0.015095999464392662 0.015135999768972397 0.015135999768972397 0.015177998691797256 0.015178000554442406 0.015217998996376991 0.015217998996376991 0.01521800085902214 0.01521800085902214 0.015258999541401863 0.015380999073386192 0.015420999377965927 0.015420999377965927 0.015461999922990799 0.015463000163435936 0.01550300046801567 0.015543000772595406 0.015583999454975128 0.015584001317620277 0.015625 0.015786999836564064 0.0157880000770092 0.015990998595952988 0.01607299968600273 0.016234999522566795 0.016234999522566795 0.01631699874997139 0.01635799929499626 0.01635800115764141 0.01648000068962574 0.016560999676585197 0.016968000680208206 0.017090000212192535
Open Search Page TTI Baseline
Mean: 621.571 ms
Stdev: 18.408 ms (3.0%)
Runs: 587.3179529998451 595.8252360001206 597.903116999194 599.1712239999324 599.9519050009549 599.9556879997253 602.5730390008539 603.7060960009694 604.3150639999658 604.628744000569 604.7156980000436 604.7924799993634 605.6411950010806 605.9472259990871 606.0083009991795 606.0508220009506 606.1387940011919 606.3214520011097 607.3486730009317 607.5581459999084 607.7753499988467 608.0699870008975 609.9316000007093 610.5301930010319 610.7417810000479 610.8213299997151 610.9250489994884 610.9566249996424 611.1060790009797 611.2910970002413 611.5158690009266 612.1459149997681 612.3000090010464 612.5249840002507 612.7668869998306 613.3450520001352 613.5746259987354 614.2225339990109 614.3314209990203 614.3836269993335 614.6009929999709 615.3449300006032 615.5161540005356 615.7131760008633 615.8192139994353 616.0753589998931 618.6463220007718 619.0330810006708 619.1829029992223 619.7905679997057 620.4793289992958 620.6770430002362 620.7492270004004 621.4456389993429 621.8044030014426 622.1153159998357 622.3421229999512 622.4237880017608 623.7161459997296 623.9710699990392 625.6901859994978 625.9852300006896 628.9315590001643 630.22220900096 630.7239589989185 633.7216389998794 635.7494299989194 636.1577150002122 636.2233480010182 636.2285970002413 637.1209309995174 637.5100909993052 640.9489749986678 642.9541840013117 646.6675620004535 652.335572000593 652.8370369989425 654.5835770014673 654.7831629998982 655.6824960000813 656.0207110010087 657.9881589990109 661.0503749996424 663.3740649987012 666.1939289998263 676.8061120007187

Current
Mean: 620.014 ms
Stdev: 16.223 ms (2.6%)
Runs: 588.6463219989091 591.078857999295 596.2650150004774 597.2392579987645 598.5729580000043 599.8588469997048 600.0476080011576 600.496296999976 600.5476070009172 600.566324999556 601.3483480010182 601.7896730005741 603.1929529998451 603.8579510003328 604.3878169991076 605.6323249991983 605.8023279998451 606.159789999947 606.6984870005399 606.944947000593 607.3789469990879 607.624878000468 607.7567950002849 608.9232179988176 609.1084399987012 609.3173840008676 609.359701000154 612.1607259996235 612.40625 612.7045499999076 613.1813969984651 613.6795659996569 613.7718100007623 614.2395430002362 614.284994000569 614.4973150007427 614.6373709999025 615.2492680009454 616.1569010000676 616.3101400006562 616.3797609992325 616.7036129999906 616.7366949990392 616.8414309993386 616.8640950005502 616.9521479997784 617.5328370016068 617.621296999976 617.7482100017369 618.3365080002695 618.8302410002798 620.2938240002841 620.3384199999273 621.0419120006263 621.6687420010567 621.8728439994156 622.1912430003285 622.2356770001352 622.4041760005057 622.7391360010952 622.9212650004774 623.2109790015966 623.3087159991264 623.4604079984128 623.6394450012594 623.6752519998699 625.2738449983299 625.5833340007812 631.2244060002267 631.34444199875 631.6676839999855 632.9694420006126 634.0713299997151 634.5129800010473 636.4676930010319 639.0581459999084 640.5799969993532 640.6568200010806 640.8179120011628 640.8433839995414 641.421590000391 649.6502689998597 652.1298420000821 653.2429200001061 653.2982179988176 653.7118330001831 654.0615640003234 655.9484459999949 656.8821210004389 658.3678390011191

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.81-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.83-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants