[$250] Workspace - Make workspace name input push to page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap profile icon
3. Tap Workspaces
4. Tap on any Workspace
5. Tap on Workspace name
6. Change Workspace name
7. Select any other currency and without tapping save option, tap app's back button
8. Tap Workspace name

Expected Result:

As user never tapped save option, on revisit, the changed Workspace name and selected currency should not be displayed

Actual Result:

On revisit, the changed Workspace name is not shown but selected currency is displayed although user never tapped save option

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6234537_1697120154927.renew_currency.1.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018ec5b209f3445160
• Upwork Job ID: 1712522664628527104
• Last Price Increase: 2023-10-27

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018ec5b209f3445160

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Upwork job price has been updated to $125

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Make workspace name input push to page

What is the root cause of that problem?

NA - Feature

What changes do you think we should make in order to solve the problem?

1. Currently we have an input registered for workspace name we need to remove that.

2. Add a menu Item MenuItem for workspace name just like we did here

   App/src/pages/workspace/WorkspaceSettingsPage.js

   Lines 153 to 164 in c559c5c

   	<View style={[styles.mt4]}>
   	<MenuItemWithTopDescription
   	title={formattedCurrency}
   	description={translate('workspace.editor.currencyInputLabel')}
   	shouldShowRightIcon
   	disabled={hasVBA}
   	onPress={onPressCurrency}
   	/>
   	<Text style={[styles.textLabel, styles.colorMuted, styles.mt2, styles.mh5]}>
   	{hasVBA ? translate('workspace.editor.currencyInputDisabledText') : translate('workspace.editor.currencyInputHelpText')}
   	</Text>
   	</View>

3. Create a new Page to handle the input and save it. Example: NewTaskTitlePage.js

4. Save the workspace name using Policy.updateGeneralSettings(policy.id, values.name.trim(), policy.outputCurrency);

5. On Save navigate user to back route.

6. Add support for the back navigation on refresh (fallback route support)

What alternative solutions did you explore? (Optional)

NA

[fedirjh]

cc @mountiny I don't think this is a bug, that is how push-to-page works, currency is updated inside the currency page selector. I think it's ideal to refactor the workspace name to a push-to-page as well.

[mountiny]

yeah its certainly weird with the Save button there, but I agree, I was also suspicious seeing the report, I will remove the blocker and we can discuss next steps

[puneetlath]

Hm, @mountiny so do you think we should do anything here? Or just close the issue?

[mountiny]

I think we should make sure there is a follow up to change the workspace name as push to page as now you have to different types of the form where one requirs you to click Save and the other one does not.

Then once the Workspace name is push to page we can remove the Save button. If there is an issue for it, we can close it I guess, if not we could use this to track it.

[melvin-bot]

@puneetlath, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

Ok I updated this issue to implement push to page for the workspace name. @b4s36t4 feel free to update your proposal.

[b4s36t4]

Updated my proposal, thanks :)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@puneetlath, @situchan Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Upwork job price has been updated to $250

[puneetlath]

I think $250 is fair here.

[melvin-bot]

@puneetlath, @b4s36t4, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

@b4s36t4 how's this going?

[b4s36t4]

@puneetlath I have completed writing the changes, it's just to take screen recordings. Will do it in sometime night.

[b4s36t4]

@puneetlath @aimane-chnaif #30733 PR is here. Thanks!!

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @b4s36t4, @aimane-chnaif eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[aimane-chnaif]

Waiting for design approval on PR

[melvin-bot]

@puneetlath, @b4s36t4, @aimane-chnaif, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[aimane-chnaif]

@puneetlath please reopen this issue as not done yet.
@b4s36t4 please let us know if we should reassign since no update for long time

[puneetlath]

@b4s36t4 bump! If we don't hear back by Monday, we'll go ahead and re-assign.

[b4s36t4]

Hey, guys. Sorry been away because of health issues for many days. Been back now will take it up and complete it ASAP.

Thanks for holding it up🙂.

[puneetlath]

I'm sorry to hear about your health issues @b4s36t4!

However, it seems like this issue is no longer relevant right? This page has been totally changed and the issue no longer seems to be happening.

Given that the PR seems to have been abandoned, I'm going to go ahead and close this issue out. Let me know if that's wrong and I've misunderstood anything.