Feat/push page ws name

[b4s36t4]

Details

Adds a Push to page method for WS screen, removes Save Button in main WS settings.

Fixed Issues

$ #29455
PROPOSAL: #29455 (comment)

Tests

• Verify that no errors appear in the JS console

1. Open WS Settings.
2. Observe the Workspace Name input is now MenuItem
3. Click on MenuItem
4. Observe the Name of WS is auto-filled.
5. Refresh the page or deeplink input should auto-focus
6. Try clicking on Save without any input value
7. Error should show.

Offline tests

Same as above

QA Steps

• Verify that no errors appear in the JS console

Same as above.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

chrome.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

safari.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

[melvin-bot]

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[aimane-chnaif]

@b4s36t4 conflicts

[b4s36t4]

@aimane-chnaif Please check now. Updated with main branch.

[aimane-chnaif]

This is in wrong position. Check other Onyx key pairs

[b4s36t4]

@aimane-chnaif Please check now, I have updated the position.

[aimane-chnaif]

@b4s36t4 also fix conflict

[b4s36t4]

@aimane-chnaif PR is ready without conflicts & your requested change. Please check.

[b4s36t4]

@aimane-chnaif Friendly bump on PR Review.

[aimane-chnaif]

Please retest after pull main. Style broken

[b4s36t4]

@aimane-chnaif You checked in only on browser right?!

[aimane-chnaif]

Tested on iOS as well. Seems happening on all platforms

[b4s36t4]

@aimane-chnaif Can you please verify now? I have tested in all platforms seems working fine.

Pushed a fix for the styling issue with currency selections.

[aimane-chnaif]

I think we should get design approval for vertical margin values. cc: @Expensify/design

• Before:

• No margin above Name, 16px margin above Currency

• 16px margin above Name, 16px margin above Currency

• No margin on both fields

[b4s36t4]

@aimane-chnaif Updated the code, please check.

[b4s36t4]

@shawnborton As you requested, I did the changes.

as per profile page - Default margin is between menus (no extra) and an extra 16px of margin top is there from WSAvatar to the menu items.

[b4s36t4]

So sorry guys, been sick for the past few days, couldn't able to do the work. Thanks for the support :)

[aimane-chnaif]

@b4s36t4 please fix conflict again

[aimane-chnaif]

@b4s36t4 bump ^

[b4s36t4]

@aimane-chnaif please check updated the code. Sorry for the delay :)

[aimane-chnaif]

@b4s36t4 another conflict

[b4s36t4]

@aimane-chnaif sorry I'm outside now. Will update the code by evening.

[aimane-chnaif]

Also fix lint after merge

[b4s36t4]

@aimane-chnaif fixed, please check :)

[aimane-chnaif]

@b4s36t4 please resolve conflict again. will complete review as soon as you've done

[aimane-chnaif]

@b4s36t4 please merge main. I will complete review during weekend

[b4s36t4]

@aimane-chnaif Done.!

[aimane-chnaif]

After pull main, lint will fail. All new files should be written in TS

[aimane-chnaif]

@b4s36t4 bump

[aimane-chnaif]

@b4s36t4 please close this PR