Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images for Expensify Card Statement Help Site Rewrite #29018

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

joekaufmanexpensify
Copy link
Contributor

@joekaufmanexpensify joekaufmanexpensify commented Oct 6, 2023

cc @rushatgabhane not sure if you are reviewing PRs to add the help site images, but LMK if you are!

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/311385
2. Please postfix PROPOSAL: with a URL link to your GitHub comment, which contains the approved proposal (i.e. the proposal that was approved by Expensify). For example, PROPOSAL: https://github.com/Expensify/App/issues/<issueID>#issuecomment-1369752925

QA Steps

Nothing to QA here, this is just uploading 3 images to be used in a help site rewrite article

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

@joekaufmanexpensify joekaufmanexpensify self-assigned this Oct 6, 2023
@joekaufmanexpensify joekaufmanexpensify requested a review from a team as a code owner October 6, 2023 16:47
@melvin-bot melvin-bot bot requested review from narefyev91 and removed request for a team October 6, 2023 16:47
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@joekaufmanexpensify joekaufmanexpensify requested review from rushatgabhane and removed request for narefyev91 October 6, 2023 16:48
@rushatgabhane
Copy link
Member

rushatgabhane commented Oct 10, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29153.

@melvin-bot melvin-bot bot requested a review from AndrewGable October 10, 2023 05:57
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcochavezf marcochavezf merged commit 69bf8e7 into main Oct 10, 2023
23 of 75 checks passed
@marcochavezf marcochavezf deleted the joekaufmanexpensify-patch-1 branch October 10, 2023 17:26
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 10, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1359.754 ms → 1498.382 ms (+138.628 ms, +10.2%) 🔴
App start runJsBundle 948.138 ms → 1029.267 ms (+81.129 ms, +8.6%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1359.754 ms
Stdev: 59.579 ms (4.4%)
Runs: 1195.2648049998097 1198.0006809998304 1241.454762000125 1249.1100679999217 1251.634924000129 1255.449390000198 1271.0970490002073 1274.2964719999582 1274.8823130000383 1284.4534080000594 1290.52994700009 1293.3440160001628 1293.869068 1297.8469199999236 1301.1820539999753 1301.553751999978 1301.6827929997817 1304.7417100002058 1315.2828119997866 1319.5797129999846 1319.7626919997856 1319.971313000191 1325.9416089998558 1326.0471339998767 1326.172180000227 1328.0765209998935 1329.7111160000786 1332.664334999863 1334.9900600002147 1338.167301000096 1339.3246709997766 1342.9739359999076 1344.9011149997823 1345.7290969998576 1346.3999350001104 1349.1788110001944 1350.6343220002018 1351.841233999934 1352.3216539998539 1357.4231469999067 1357.6013079998083 1358.1216290001757 1360.4599819998257 1362.1418510000221 1362.190671000164 1363.832830999978 1368.6615860001184 1369.409155999776 1370.6643420001492 1372.18142300006 1374.2766700000502 1377.3343949997798 1378.7974200001918 1381.2869779998437 1382.3417910002172 1383.170382999815 1383.249344999902 1383.8180970000103 1384.277410000097 1385.8342510000803 1389.4288220000453 1389.8877779999748 1394.463620999828 1400.414716000203 1400.7654340001754 1401.1711760000326 1403.74223600002 1404.9865549998358 1405.2905640001409 1406.779428999871 1409.0223260000348 1409.173398999963 1411.174046 1412.177835999988 1418.9179899999872 1419.9707729998045 1423.7236850000918 1427.6500169998035 1428.1417919998057 1432.766820000019 1442.45182499988 1442.9097589999437 1443.8171520000324 1448.0405760002322 1453.0327320001088 1457.9908699998632 1458.7453870000318 1470.0617920001969 1474.2752479999326

Current
Mean: 1498.382 ms
Stdev: 76.622 ms (5.1%)
Runs: 1291.6216589999385 1320.4425189998 1344.2892649997957 1367.0650379997678 1373.1227330002002 1377.352555999998 1379.271486000158 1381.4608149998821 1385.412202999927 1387.5997379999608 1389.4062189999968 1401.7145799999125 1404.2417460000142 1410.105177000165 1412.4504269999452 1413.2912269998342 1415.5481770001352 1434.191511000041 1435.216041999869 1437.3400880000554 1439.7450740002096 1443.0161089999601 1443.9982699998654 1449.0919909998775 1450.248323999811 1456.3080480000935 1457.1952069997787 1463.0637619998306 1464.4025699999183 1470.3848029999062 1473.6318720001727 1474.4851580001414 1476.295682999771 1479.6941419998184 1485.1396019998938 1487.7505950001068 1488.72082399996 1489.096710999962 1491.429936000146 1496.3651089998893 1496.503363000229 1497.7303659999743 1498.9994600000791 1499.6862119999714 1500.554057000205 1501.4181570000947 1501.9433510000817 1506.3132070000283 1507.8750829999335 1510.4629739997908 1511.8085590000264 1516.3246439998038 1517.4092489997856 1519.1547469999641 1523.9074349999428 1525.6001499998383 1525.768033000175 1525.8567769997753 1532.367320000194 1533.1877910001203 1536.1988010001369 1536.7642850000411 1540.4331000000238 1541.3087479998358 1549.033063000068 1550.8236529999413 1556.0836350000463 1557.4577879998833 1557.8574149999768 1559.388964000158 1560.221516000107 1566.3135040001944 1566.739064999856 1566.9697289997712 1572.7576649999246 1572.9566730000079 1573.1193420002237 1578.966936999932 1582.5776999997906 1584.1731500001624 1585.700019000098 1586.1996450000443 1591.1432659998536 1593.9211019999348 1600.6237739999779 1602.1426900001243 1612.7723240000196 1624.8956419997849 1645.3430800000206 1648.3121389998123 1657.5215690000914
App start runJsBundle Baseline
Mean: 948.138 ms
Stdev: 44.350 ms (4.7%)
Runs: 841 843 847 863 872 880 881 884 886 887 890 894 900 905 907 908 909 913 915 918 919 921 924 926 928 930 930 931 933 935 935 936 942 942 943 943 944 944 944 946 947 947 951 951 952 952 953 954 954 955 958 958 961 961 962 965 966 967 968 969 969 969 970 973 976 976 976 976 980 983 983 983 986 987 993 998 999 1003 1003 1006 1006 1011 1018 1030 1034 1050 1060

Current
Mean: 1029.267 ms
Stdev: 56.952 ms (5.5%)
Runs: 904 919 921 922 923 924 933 935 940 941 941 942 964 969 969 972 974 980 981 984 987 990 995 999 1001 1002 1003 1005 1007 1010 1015 1016 1017 1019 1022 1022 1022 1023 1025 1028 1030 1031 1033 1034 1034 1035 1038 1038 1039 1040 1040 1041 1042 1043 1044 1047 1048 1049 1051 1053 1055 1056 1058 1058 1059 1060 1062 1063 1065 1067 1067 1069 1074 1077 1079 1088 1095 1096 1097 1100 1105 1109 1115 1117 1121 1122 1129 1135 1138 1142

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 658.440 ms → 675.397 ms (+16.957 ms, +2.6%)
App start nativeLaunch 21.807 ms → 24.455 ms (+2.648 ms, +12.1%)
App start regularAppStart 0.016 ms → 0.018 ms (+0.002 ms, +12.3%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 658.440 ms
Stdev: 35.360 ms (5.4%)
Runs: 606.4913329998963 609.8247890002094 610.2040209998377 610.8306069998071 612.2415370000526 612.5353999999352 615.0635179998353 616.190510999877 618.8515220000409 619.5845139999874 620.886758999899 623.0203050002456 625.3480230001733 627.3898930000141 628.7084560003132 628.8474129997194 629.0422360002995 629.4568279995583 629.5622969996184 629.7486169999465 631.289145000279 633.3615319998935 633.3637290000916 635.0131430001929 635.4811610002071 635.5526130003855 636.3355720001273 637.1864419998601 637.2030850001611 637.3810229999945 637.746460000053 637.8984789997339 641.229248999618 641.5474049998447 641.7623290000483 642.6895759999752 642.7883309996687 643.0531820002943 643.7621669997461 645.247762999963 646.1180830001831 648.1112070004456 648.65393100027 649.4378670002334 649.4711919999681 649.4736739997752 649.5230310000479 650.3155930000357 651.1748049999587 651.7996429996565 652.2834069998935 652.4995120000094 653.6559649999253 654.3398029999807 655.7355959997512 656.4781899997033 658.2765299999155 659.6884760004468 659.718586999923 660.9401039998047 662.4075120002963 666.8201500000432 667.3865160001442 669.9781899997033 672.3433030000888 674.0970059996471 676.4937749998644 679.3358570002019 682.238241000101 682.4394940002821 685.097250000108 685.2264410001226 688.5273029999807 690.0984710003249 701.7753909998573 705.7526859999634 708.1518560000695 710.0917559997179 711.9860440003686 712.3585620000958 715.0575769999996 717.4274909999222 717.7861330001615 723.0139979999512 723.1208500000648 734.7127689998597 736.0269369999878 738.5742999999784 741.5677490001544 748.3149020001292

Current
Mean: 675.397 ms
Stdev: 23.071 ms (3.4%)
Runs: 619.847289999947 629.7880869996734 631.5103350002319 632.4348149998114 636.5316579998471 640.1685390002094 644.0158290001564 645.6737879998982 647.069540000055 648.2721349997446 649.0962320002727 652.4270019996911 653.3347980002873 654.2848720001057 654.906086999923 655.5319819999859 659.2412929995917 659.490233999677 659.5462239999324 660.3332110000774 660.6402190001681 660.8119299998507 661.3220220003277 661.5482999999076 661.9276530002244 663.0079760001972 663.5273850001395 663.6790360002778 664.119141000323 665.5721040000208 665.6636159997433 665.9298099996522 666.1328130001202 666.3153079999611 667.571858999785 667.7918700003065 668.2217620001175 668.4168699998409 668.8676360002719 669.2355549996719 669.4777830000967 669.881550999824 670.0353610003367 670.1997480001301 670.2087809997611 671.0967620001175 672.2895109998062 672.8483890001662 673.5248219999485 674.045167000033 675.1067710001953 675.7236339999363 676.8422449999489 677.4015709999949 677.9466550000943 678.0115150003694 678.3077400000766 678.6762699997053 678.9870600001886 679.1082760002464 680.0753990001976 680.1770019996911 681.571858999785 683.6273610000499 683.9023029999807 687.3384199999273 689.4171959999949 689.9989430001006 690.5834959996864 691.6046960004605 692.3232019999996 693.2559420000762 697.2923179999925 697.5532639999874 697.6044109999202 698.2091479999945 701.8451749999076 702.6403410001658 704.1822920003906 708.0795080000535 708.4636639999226 708.5545250000432 709.3652749997564 710.5178629998118 713.344076000154 713.6301270001568 716.819540000055 723.1124269999564 726.5737310000695 727.478964000009 728.4644369999878
App start nativeLaunch Baseline
Mean: 21.807 ms
Stdev: 2.444 ms (11.2%)
Runs: 18 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 25 25 25 25 25 26 27 27 27 27 29 30

Current
Mean: 24.455 ms
Stdev: 2.771 ms (11.3%)
Runs: 19 20 20 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 24 24 24 24 25 25 25 25 25 25 25 25 25 25 26 26 26 26 26 26 26 27 27 27 27 27 27 28 28 28 28 28 28 29 29 30 31 31 32 33
App start regularAppStart Baseline
Mean: 0.016 ms
Stdev: 0.001 ms (6.7%)
Runs: 0.013428000267595053 0.013630999717861414 0.0138349998742342 0.013916000258177519 0.014444999862462282 0.014525999780744314 0.01472900016233325 0.014851000159978867 0.0148930000141263 0.014933000318706036 0.015054999850690365 0.01509599993005395 0.015136000234633684 0.015137000009417534 0.015177999623119831 0.015178000088781118 0.015218000393360853 0.015257999766618013 0.01525900000706315 0.015339999925345182 0.015340999700129032 0.015381000004708767 0.015422000084072351 0.015461999922990799 0.015503000002354383 0.015544000081717968 0.015583999920636415 0.015625 0.015665000304579735 0.015666000079363585 0.015666000079363585 0.015666000079363585 0.01570700015872717 0.015746999997645617 0.015746999997645617 0.015910000074654818 0.015949999913573265 0.015950000379234552 0.015951000154018402 0.015951000154018402 0.01599099999293685 0.01599099999293685 0.016114000231027603 0.016193999908864498 0.016194000374525785 0.016234999988228083 0.016315999906510115 0.016316999681293964 0.01631700014695525 0.0163569999858737 0.016398000065237284 0.016398000065237284 0.01643799990415573 0.016439000144600868 0.016479999758303165 0.016480000223964453 0.016480000223964453 0.0165200000628829 0.0165200000628829 0.016600999981164932 0.01660200022161007 0.016642000060528517 0.016724000219255686 0.016763999592512846 0.016764000058174133 0.016885999590158463 0.01688600005581975 0.0168869998306036 0.016927000135183334 0.01696799974888563 0.017089999746531248 0.017171999905258417 0.0172520000487566 0.017253000289201736 0.017293999902904034 0.01733400020748377 0.017496999818831682 0.01749700028449297 0.017578000202775 0.0176189998164773 0.017822000198066235 0.01822900027036667 0.01859599957242608 0.018757999874651432 0.018920999951660633

Current
Mean: 0.018 ms
Stdev: 0.001 ms (7.4%)
Runs: 0.014851999934762716 0.015585000161081553 0.015705999918282032 0.016152999829500914 0.016234999988228083 0.016234999988228083 0.016276000067591667 0.016316999681293964 0.016358000226318836 0.016358000226318836 0.016519999597221613 0.0165200000628829 0.016521000303328037 0.016642000060528517 0.0166830001398921 0.016764000058174133 0.01680499967187643 0.016805000137537718 0.01688600005581975 0.016926999669522047 0.016927000135183334 0.01696800021454692 0.0170499999076128 0.017090000212192535 0.017171999905258417 0.017292999662458897 0.017374999821186066 0.017374999821186066 0.0174150001257658 0.017416000366210938 0.01753699965775013 0.017659000121057034 0.017700000200420618 0.017700000200420618 0.017741000279784203 0.01778100011870265 0.017821999732404947 0.017822000198066235 0.017903999891132116 0.0179449999704957 0.01806599972769618 0.018188999965786934 0.01822899980470538 0.018269999884068966 0.018269999884068966 0.018309999722987413 0.01831099996343255 0.01831099996343255 0.018351000268012285 0.018351000268012285 0.018391999881714582 0.01843199972063303 0.018473000265657902 0.0185139998793602 0.0185139998793602 0.0185139998793602 0.0185139998793602 0.01859499979764223 0.018635999877005816 0.018635999877005816 0.018635999877005816 0.018635999877005816 0.0186769999563694 0.018757999874651432 0.018757999874651432 0.0188400000333786 0.01887999987229705 0.019083000253885984 0.019084000028669834 0.01912500010803342 0.019327000249177217 0.019328000023961067 0.019367999862879515 0.0194089999422431 0.0194089999422431 0.019409000407904387 0.019532000180333853 0.019652999937534332 0.019898000173270702 0.01993800001218915 0.020060000009834766 0.020305000245571136 0.020548000000417233 0.020671000238507986 0.020793000236153603 0.02136299991980195 0.021443000063300133

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@joekaufmanexpensify
Copy link
Contributor Author

Not sure if anything is needed for this. Asking here.

@joekaufmanexpensify
Copy link
Contributor Author

Confirmed in the above thread we can ignore this performance/regression message, as it is not applicable here

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.81-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.83-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants