-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set authToken
and email
cookies from NewDot
#29089
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
does this require my review? |
@rushatgabhane yep please do the code review and do basic check that App generally works as expected |
@situchan let me know when you finish the checklist so that I can merge 🙇 |
document.cookie = `authToken=${session.authToken}; domain=expensify.com.dev; path=/;`; | ||
document.cookie = `email=${session.email}; domain=expensify.com.dev; path=/;`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's worth but maybe we can early return when either of authToken or email doesn't exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a situation when these values are not defined because IFrame component is displayed only if the user is logged in 🤔
or do you think we're missing any exceptions to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok it's fine if no case
Deploying with Cloudflare Pages
|
Reviewer Checklist
Screenshots/VideosMobile Web - ChromeMobile Web - SafariDesktopAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App works fine as normal
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.81-0 🚀
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.83-0 🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/324273
PROPOSAL: N/A
Tests
This component
IFrame
is not used yet. Test the feature when @adamgrzybowski (SWM engineer) opens a PR that uses this component.For this PR, just running the app and check it still works is enough.
Offline tests
N/A
QA Steps
NO QA
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
N/A
Mobile Web - Chrome
N/A
Mobile Web - Safari
N/A
Desktop
N/A
iOS
N/A
Android
N/A