-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated room name regex to that accept the all lowercase letters using unicode and removed the à-ÿ range #29168
Updated room name regex to that accept the all lowercase letters using unicode and removed the à-ÿ range #29168
Conversation
@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -1264,7 +1264,7 @@ const CONST = { | |||
CARD_NUMBER: /^[0-9]{15,16}$/, | |||
CARD_SECURITY_CODE: /^[0-9]{3,4}$/, | |||
CARD_EXPIRATION_DATE: /^(0[1-9]|1[0-2])([^0-9])?([0-9]{4}|([0-9]{2}))$/, | |||
ROOM_NAME: /^#[a-z0-9à-ÿ-]{1,80}$/, | |||
ROOM_NAME: /^#[\p{Ll}0-9-]{1,80}$/u, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xmiroslav \p{Ll}
will include the lowercase letters from any language, e.g., Greek and Cyrillic alphabets will also be valid.
And if we want to accept only Latin lowercase characters explicitly, we must adjust the regex accordingly.
Then We have to use this regex /^#(?:((?=\p{Script=Latin})\p{Ll})|[0-9-]){1,80}$/u
that will check the Latin script lowercase alphabets only, above regex will create positive lookahead, which asserts that the following character(s) are Latin script characters which following by lowercase letter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support other languages yet than Spanish, but I think it's fine to accept alphabets from other languages.
@thienlnam what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think that's fine to accept other language alphabets
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromemchrome.movMobile Web - Safarimsafari.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.81-0 🚀
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.83-0 🚀
|
Details
Fixed Issues
$ #28806
PROPOSAL: #28806 (comment)
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.mov
Android: mWeb Chrome
mWeb-chrome.mov
iOS: Native
iOS.mov
iOS: mWeb Safari
mWeb-safari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
dsktop.mov