[PAY-3882] Update client collectibles handling #11312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0deaf9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schottra
requested review from
amendelsohn,
raymondjacobson and
dylanjeffers
and removed request for
amendelsohn
raymondjacobson
approved these changes
Feb 7, 2025
| @@ -28,25 +27,6 @@ export const useUpdateProfile = () => { | |||
| const sdk = await audiusSdk() | |||
| metadata.bio = squashNewLines(metadata.bio ?? null) | |||
|
|
|||
| // Get existing metadata and combine with it | |||
…ibles * origin/main: (71 commits) [PAY-3881][PAY-3883] Add indexing/endpoints for separated collectibles data (#11287) [C5778] Update web profile page layout (#11374) Test listen streak challenge 2 listens in 1 day (#11373) Listen streak challenge fix 2 plays in one day (#11372) Randomize storage node ordering in StorageNodeSelector. (#11371) Disable endless listen streak challenge, delete rows (#11369) Fix user-link overflow (#11370) MRVR country fixes (#11118) [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) 🪦 poa ganache (#11367) Fix playlist invalid sort test (#11368) core block diff health check (#11365) Audius Protocol v0.7.90 Hide endless challenge audio (#11364) [C-5769] Use batch fetching to normalize core entity hooks (#11355) entity manager through core on dev (#11359) fix lint (#11362) Fix plays indexing starvation (#11361) Revert "filter chain health on these nodes" (#11358) Tag audiusd with protocol releases to allow reverts (#11347) ...
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11648678 | Triggered | Generic High Entropy Secret | 0deaf9e | dev-tools/environment/audiusd-4.env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
audius-infra
pushed a commit
that referenced
this pull request
Feb 15, 2025
[341ca35] Fix infinite query return args (#11384) Dylan Jeffers [82c97e4] [C-5766] Paginate profile collections (#11375) Dylan Jeffers [5f61f37] [C-5771 QA-1983] Fix harmony white and static white (#11383) Dylan Jeffers [4cbd971] [C-1984] Improve left-nav buttons with IconButton improvements (#11382) Dylan Jeffers [4066498] [C-5782, C-5783] Add user comments endpoint and tan query hook (#11366) Kyle Shanks [96cfea5] [C-5768] New fetch single entity pattern (#11318) Andrew Mendelsohn [1056ad1] [PAY-3882] Update client collectibles handling (#11312) Randy Schott [e718ce9] [C5778] Update web profile page layout (#11374) Randy Schott [b68d0c1] Fix user-link overflow (#11370) Dylan Jeffers [3d33536] [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) Dylan Jeffers [77fdd02] Hide endless challenge audio (#11364) Dylan Jeffers [bfab8f0] [C-5769] Use batch fetching to normalize core entity hooks (#11355) Andrew Mendelsohn [e85347a] [C-5763 C-5603] Migrate profile collections to tan-query (#11285) Dylan Jeffers [48ba8aa] [C-5767] Migrate related-artists to tan-query #2 (#11303) Dylan Jeffers [0c7e2e7] Format number commas in reward notifs (#11356) Reed [b73cf1f] [PAY-3941] Claim all rewards tile respects optimistic challenges (#11352) Reed [e9e19d9] Filter out listen streak endless notifications (#11353) Reed [514ce3f] Don't show oneshot expiry if ineligible (#11351) Reed [7147843] Ineligible oneshot instead of incomplete on mobile (#11350) Reed [d053519] Format number commas for all reward amounts (#11349) Reed [dcca08b] Feature flag on claim all button (#11345) Isaac Solo [f6aef59] [QA-1909] Fix playlist menu min-width (#11344) Dylan Jeffers [ac02b23] [QA-1772] Fix windows app frame (#11340) Dylan Jeffers [6ca3797] [QA-1768] Improve now playing drawer close arrow (#11339) Dylan Jeffers [1b1f4a8] Update dapp-store build artifacts audius-infra [2fec196] [QA-1891] Fix track tile icon clipping and zero state (#11338) Dylan Jeffers [a35337a] Airdrop pt one migration (#11335) Isaac Solo [3d5c629] [QA-1959] Hide referred tile with new challenge name (#11336) Reed [dab4766] Fix reward claim error gap too large (#11337) Reed [7a7c962] Fix harmony and web lint (#11332) Dylan Jeffers [ce10a10] Bump android version to 468 (#11331) Dylan Jeffers [42374fe] Fix explore page featured content (#11321) Dylan Jeffers [97aa11b] Sign out from oauth should not go to trending (#11327) Isaac Solo [d11f31c] Update airdrop copy and add X icon (#11306) Isaac Solo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #11287 .
A note about terminology: "Profile collectibles" refers to the structure we use to determine user-specified ordering of collectibles via the edit flow on the profile page. We load and store eth/sol collectibles for a user separately and then use the (potentially undefined) profile collectibles structure to determine which collectibles we already know about and the order the user has specified. It is only this structure that was stored in CID data. So only that has been migrated.
This updates client code to use the new endpoint for fetching profile collectibles and to use the new transactions for updating the collectibles preferences.
It also migrates the fetching of the profile collectibles to use tan-query.
How Has This Been Tested?
I ran local web/mobile clients against a local stack and tested all the flows I could find that used collectibles data. The most important thing changed was making sure we can change collectibles ordering and that the change sticks.