Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lint #11362

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix lint #11362

merged 1 commit into from
Feb 13, 2025

Conversation

alecsavvy
Copy link
Contributor

@alecsavvy alecsavvy commented Feb 13, 2025 •
edited
Loading

Description

lint got busted by a few prs, this fixes the lint

How Has This Been Tested?

CI

@alecsavvy alecsavvy self-assigned this Feb 13, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: a32d8d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alecsavvy alecsavvy requested a review from isaacsolo February 13, 2025 00:39
dylanjeffers
dylanjeffers approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!! My bad

@alecsavvy alecsavvy enabled auto-merge (squash) February 13, 2025 00:40
rickyrombo
rickyrombo approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@rickyrombo rickyrombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - do you have any thoughts on how to fix the VS code auto formatting? Seems to be broken rn

@alecsavvy
Copy link
Contributor Author

@rickyrombo the vscode auto/re-formatting is what I used to fix this so i'm not sure. I'll check in my settings.

@alecsavvy
Copy link
Contributor Author

@rickyrombo I just seem to have defaults that come with the normal python extensions. Maybe something is different between vscode and cursor. I'm using vscode with the same settings i've always had.

@alecsavvy alecsavvy disabled auto-merge February 13, 2025 00:48
@alecsavvy alecsavvy merged commit e8eb855 into main Feb 13, 2025
4 of 6 checks passed
@alecsavvy alecsavvy deleted the as/fix-lint-2 branch February 13, 2025 00:48
@rickyrombo
Copy link
Contributor

@rickyrombo I just seem to have defaults that come with the normal python extensions. Maybe something is different between vscode and cursor. I'm using vscode with the same settings i've always had.

Interesting! I think Reed and I both have had some issues with the black formatter behaving differently w/ vscode plugin vs running the lint.sh

@alecsavvy
Copy link
Contributor Author

Yeah I ran the lint.sh to find the problematic files, went to them in vscode and then did cmd + P > format file lol

audius-infra pushed a commit that referenced this pull request Feb 13, 2025
Audius Protocol v0.7.90
d03ff55 
[3932be3] entity manager through core on dev (#11359) alecsavvy
[e8eb855] fix lint (#11362) alecsavvy
[42944f4] Fix plays indexing starvation (#11361) Isaac Solo
[9fa5f75] Revert "filter chain health on these nodes" (#11358) alecsavvy
[e85347a] [C-5763 C-5603] Migrate profile collections to tan-query (#11285) Dylan Jeffers
[48ba8aa] [C-5767] Migrate related-artists to tan-query #2 (#11303) Dylan Jeffers
schottra added a commit that referenced this pull request Feb 13, 2025
@schottra
Merge remote-tracking branch 'origin/main' into profile-layout-updates
ba7e480 
* origin/main: (21 commits)
  Test listen streak challenge 2 listens in 1 day (#11373)
  Listen streak challenge fix 2 plays in one day (#11372)
  Randomize storage node ordering in StorageNodeSelector. (#11371)
  Disable endless listen streak challenge, delete rows (#11369)
  Fix user-link overflow (#11370)
  MRVR country fixes (#11118)
  [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360)
  🪦 poa ganache (#11367)
  Fix playlist invalid sort test (#11368)
  core block diff health check (#11365)
  Audius Protocol v0.7.90
  Hide endless challenge audio (#11364)
  [C-5769] Use batch fetching to normalize core entity hooks (#11355)
  entity manager through core on dev (#11359)
  fix lint (#11362)
  Fix plays indexing starvation (#11361)
  Revert "filter chain health on these nodes" (#11358)
  Tag audiusd with protocol releases to allow reverts (#11347)
  [C-5763 C-5603] Migrate profile collections to tan-query (#11285)
  [C-5767] Migrate related-artists to tan-query #2 (#11303)
  ...
schottra added a commit that referenced this pull request Feb 14, 2025
@schottra
Merge remote-tracking branch 'origin/main' into update-client-collect…
0deaf9e 
…ibles

* origin/main: (71 commits)
  [PAY-3881][PAY-3883] Add indexing/endpoints for separated collectibles data (#11287)
  [C5778] Update web profile page layout (#11374)
  Test listen streak challenge 2 listens in 1 day (#11373)
  Listen streak challenge fix 2 plays in one day (#11372)
  Randomize storage node ordering in StorageNodeSelector. (#11371)
  Disable endless listen streak challenge, delete rows (#11369)
  Fix user-link overflow (#11370)
  MRVR country fixes (#11118)
  [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360)
  🪦 poa ganache (#11367)
  Fix playlist invalid sort test (#11368)
  core block diff health check (#11365)
  Audius Protocol v0.7.90
  Hide endless challenge audio (#11364)
  [C-5769] Use batch fetching to normalize core entity hooks (#11355)
  entity manager through core on dev (#11359)
  fix lint (#11362)
  Fix plays indexing starvation (#11361)
  Revert "filter chain health on these nodes" (#11358)
  Tag audiusd with protocol releases to allow reverts (#11347)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyrombo rickyrombo rickyrombo approved these changes

@dylanjeffers dylanjeffers dylanjeffers approved these changes

@isaacsolo isaacsolo Awaiting requested review from isaacsolo

Assignees

@alecsavvy alecsavvy

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alecsavvy @rickyrombo @dylanjeffers