-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomize storage node ordering in StorageNodeSelector. #11371
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, should we remove audiusWalletClient from config?
* origin/main: (21 commits) Test listen streak challenge 2 listens in 1 day (#11373) Listen streak challenge fix 2 plays in one day (#11372) Randomize storage node ordering in StorageNodeSelector. (#11371) Disable endless listen streak challenge, delete rows (#11369) Fix user-link overflow (#11370) MRVR country fixes (#11118) [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) 🪦 poa ganache (#11367) Fix playlist invalid sort test (#11368) core block diff health check (#11365) Audius Protocol v0.7.90 Hide endless challenge audio (#11364) [C-5769] Use batch fetching to normalize core entity hooks (#11355) entity manager through core on dev (#11359) fix lint (#11362) Fix plays indexing starvation (#11361) Revert "filter chain health on these nodes" (#11358) Tag audiusd with protocol releases to allow reverts (#11347) [C-5763 C-5603] Migrate profile collections to tan-query (#11285) [C-5767] Migrate related-artists to tan-query #2 (#11303) ...
…ibles * origin/main: (71 commits) [PAY-3881][PAY-3883] Add indexing/endpoints for separated collectibles data (#11287) [C5778] Update web profile page layout (#11374) Test listen streak challenge 2 listens in 1 day (#11373) Listen streak challenge fix 2 plays in one day (#11372) Randomize storage node ordering in StorageNodeSelector. (#11371) Disable endless listen streak challenge, delete rows (#11369) Fix user-link overflow (#11370) MRVR country fixes (#11118) [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) 🪦 poa ganache (#11367) Fix playlist invalid sort test (#11368) core block diff health check (#11365) Audius Protocol v0.7.90 Hide endless challenge audio (#11364) [C-5769] Use batch fetching to normalize core entity hooks (#11355) entity manager through core on dev (#11359) fix lint (#11362) Fix plays indexing starvation (#11361) Revert "filter chain health on these nodes" (#11358) Tag audiusd with protocol releases to allow reverts (#11347) ...
Description
Previously a given user would get a static node ordering. Users with an unfortunate ordering could have higher rate of errors.
This should randomize the order for a given session. User will get a new ordering boot, so reloading page is enough to re-randomize.