Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize storage node ordering in StorageNodeSelector. #11371

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

stereosteve
Copy link
Contributor

Description

Previously a given user would get a static node ordering. Users with an unfortunate ordering could have higher rate of errors.

This should randomize the order for a given session. User will get a new ordering boot, so reloading page is enough to re-randomize.

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 271c336

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, should we remove audiusWalletClient from config?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 13, 2025
@stereosteve stereosteve merged commit 908e75c into main Feb 13, 2025
7 checks passed
@stereosteve stereosteve deleted the sdk-randomize-storage-node-order branch February 13, 2025 20:15
schottra added a commit that referenced this pull request Feb 13, 2025
* origin/main: (21 commits)
  Test listen streak challenge 2 listens in 1 day (#11373)
  Listen streak challenge fix 2 plays in one day (#11372)
  Randomize storage node ordering in StorageNodeSelector. (#11371)
  Disable endless listen streak challenge, delete rows (#11369)
  Fix user-link overflow (#11370)
  MRVR country fixes (#11118)
  [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360)
  🪦 poa ganache (#11367)
  Fix playlist invalid sort test (#11368)
  core block diff health check (#11365)
  Audius Protocol v0.7.90
  Hide endless challenge audio (#11364)
  [C-5769] Use batch fetching to normalize core entity hooks (#11355)
  entity manager through core on dev (#11359)
  fix lint (#11362)
  Fix plays indexing starvation (#11361)
  Revert "filter chain health on these nodes" (#11358)
  Tag audiusd with protocol releases to allow reverts (#11347)
  [C-5763 C-5603] Migrate profile collections to tan-query (#11285)
  [C-5767] Migrate related-artists to tan-query #2 (#11303)
  ...
schottra added a commit that referenced this pull request Feb 14, 2025
…ibles

* origin/main: (71 commits)
  [PAY-3881][PAY-3883] Add indexing/endpoints for separated collectibles data (#11287)
  [C5778] Update web profile page layout (#11374)
  Test listen streak challenge 2 listens in 1 day (#11373)
  Listen streak challenge fix 2 plays in one day (#11372)
  Randomize storage node ordering in StorageNodeSelector. (#11371)
  Disable endless listen streak challenge, delete rows (#11369)
  Fix user-link overflow (#11370)
  MRVR country fixes (#11118)
  [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360)
  🪦 poa ganache (#11367)
  Fix playlist invalid sort test (#11368)
  core block diff health check (#11365)
  Audius Protocol v0.7.90
  Hide endless challenge audio (#11364)
  [C-5769] Use batch fetching to normalize core entity hooks (#11355)
  entity manager through core on dev (#11359)
  fix lint (#11362)
  Fix plays indexing starvation (#11361)
  Revert "filter chain health on these nodes" (#11358)
  Tag audiusd with protocol releases to allow reverts (#11347)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants