[C-5767] Migrate related-artists to tan-query #2 #11303

dylanjeffers · 2025-02-07T04:58:26Z

Description

Reapplies related-artist code, fixing backend change

changeset-bot · 2025-02-07T04:58:31Z

⚠️ No Changeset found

Latest commit: cdef8f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian · 2025-02-09T19:28:16Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11648678	Triggered	Generic High Entropy Secret	`c231efe`	dev-tools/environment/audiusd-4.env	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

amendelsohn

Ship it!

amendelsohn · 2025-02-11T00:48:29Z

packages/discovery-provider/src/api/v1/users.py

+    required=False,
+    type=inputs.boolean,
+    default=False,
+    description="If true, filters out artists that the current user already follows",


amendelsohn · 2025-02-11T00:50:58Z

packages/mobile/src/components/suggested-follows/SuggestedFollows.tsx

 const useStyles = makeStyles(({ spacing, palette }) => ({
  root: {
-    flex: 1
+    flex: 1,
+    height: height - 220


what's 220?

amendelsohn · 2025-02-11T00:51:57Z

packages/mobile/src/screens/profile-screen/ArtistRecommendations/ArtistRecommendations.tsx

  useEffect(() => {
-    if (!isEmpty(suggestedArtists)) {
-      setIdsToFollow(suggestedArtists.map((user) => user.user_id).slice(0, 5))
+    if (suggestedArtists && !isEmpty(suggestedArtists)) {


does isEmpty not check truthiness? :(

yeah it's so typescript is happy when i unconditionally .map suggestedArtists

[3932be3] entity manager through core on dev (#11359) alecsavvy [e8eb855] fix lint (#11362) alecsavvy [42944f4] Fix plays indexing starvation (#11361) Isaac Solo [9fa5f75] Revert "filter chain health on these nodes" (#11358) alecsavvy [e85347a] [C-5763 C-5603] Migrate profile collections to tan-query (#11285) Dylan Jeffers [48ba8aa] [C-5767] Migrate related-artists to tan-query #2 (#11303) Dylan Jeffers

* origin/main: (21 commits) Test listen streak challenge 2 listens in 1 day (#11373) Listen streak challenge fix 2 plays in one day (#11372) Randomize storage node ordering in StorageNodeSelector. (#11371) Disable endless listen streak challenge, delete rows (#11369) Fix user-link overflow (#11370) MRVR country fixes (#11118) [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) 🪦 poa ganache (#11367) Fix playlist invalid sort test (#11368) core block diff health check (#11365) Audius Protocol v0.7.90 Hide endless challenge audio (#11364) [C-5769] Use batch fetching to normalize core entity hooks (#11355) entity manager through core on dev (#11359) fix lint (#11362) Fix plays indexing starvation (#11361) Revert "filter chain health on these nodes" (#11358) Tag audiusd with protocol releases to allow reverts (#11347) [C-5763 C-5603] Migrate profile collections to tan-query (#11285) [C-5767] Migrate related-artists to tan-query #2 (#11303) ...

[341ca35] Fix infinite query return args (#11384) Dylan Jeffers [82c97e4] [C-5766] Paginate profile collections (#11375) Dylan Jeffers [5f61f37] [C-5771 QA-1983] Fix harmony white and static white (#11383) Dylan Jeffers [4cbd971] [C-1984] Improve left-nav buttons with IconButton improvements (#11382) Dylan Jeffers [4066498] [C-5782, C-5783] Add user comments endpoint and tan query hook (#11366) Kyle Shanks [96cfea5] [C-5768] New fetch single entity pattern (#11318) Andrew Mendelsohn [1056ad1] [PAY-3882] Update client collectibles handling (#11312) Randy Schott [e718ce9] [C5778] Update web profile page layout (#11374) Randy Schott [b68d0c1] Fix user-link overflow (#11370) Dylan Jeffers [3d33536] [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) Dylan Jeffers [77fdd02] Hide endless challenge audio (#11364) Dylan Jeffers [bfab8f0] [C-5769] Use batch fetching to normalize core entity hooks (#11355) Andrew Mendelsohn [e85347a] [C-5763 C-5603] Migrate profile collections to tan-query (#11285) Dylan Jeffers [48ba8aa] [C-5767] Migrate related-artists to tan-query #2 (#11303) Dylan Jeffers [0c7e2e7] Format number commas in reward notifs (#11356) Reed [b73cf1f] [PAY-3941] Claim all rewards tile respects optimistic challenges (#11352) Reed [e9e19d9] Filter out listen streak endless notifications (#11353) Reed [514ce3f] Don't show oneshot expiry if ineligible (#11351) Reed [7147843] Ineligible oneshot instead of incomplete on mobile (#11350) Reed [d053519] Format number commas for all reward amounts (#11349) Reed [dcca08b] Feature flag on claim all button (#11345) Isaac Solo [f6aef59] [QA-1909] Fix playlist menu min-width (#11344) Dylan Jeffers [ac02b23] [QA-1772] Fix windows app frame (#11340) Dylan Jeffers [6ca3797] [QA-1768] Improve now playing drawer close arrow (#11339) Dylan Jeffers [1b1f4a8] Update dapp-store build artifacts audius-infra [2fec196] [QA-1891] Fix track tile icon clipping and zero state (#11338) Dylan Jeffers [a35337a] Airdrop pt one migration (#11335) Isaac Solo [3d5c629] [QA-1959] Hide referred tile with new challenge name (#11336) Reed [dab4766] Fix reward claim error gap too large (#11337) Reed [7a7c962] Fix harmony and web lint (#11332) Dylan Jeffers [ce10a10] Bump android version to 468 (#11331) Dylan Jeffers [42374fe] Fix explore page featured content (#11321) Dylan Jeffers [97aa11b] Sign out from oauth should not go to trending (#11327) Isaac Solo [d11f31c] Update airdrop copy and add X icon (#11306) Isaac Solo

dylanjeffers added 3 commits February 6, 2025 20:47

Migrate related-artists to use tan-query

a280967

Upgrades elasticsearch to 8.17.1

47ec612

Fix related artists query

8ce4cc8

pull-request-size bot added the size/XXL label Feb 7, 2025

dylanjeffers added 2 commits February 9, 2025 10:25

Merge branch 'main' into reapply-related-artists

c231efe

Fixes

40b751a

dylanjeffers added 4 commits February 10, 2025 15:54

Merge branch 'main' into reapply-related-artists

24137e0

Merge branch 'main' into reapply-related-artists

50fb53d

Lint fix

e5d3485

Cleanup tests

cdef8f0

dylanjeffers changed the title ~~[C-5601] Migrate related-artists to tan-query #2~~ [C-5767] Migrate related-artists to tan-query #2 Feb 11, 2025

dylanjeffers requested a review from amendelsohn February 11, 2025 00:40

amendelsohn approved these changes Feb 11, 2025

View reviewed changes

dylanjeffers merged commit 48ba8aa into main Feb 12, 2025
12 checks passed

dylanjeffers deleted the reapply-related-artists branch February 12, 2025 19:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-5767] Migrate related-artists to tan-query #2 #11303

[C-5767] Migrate related-artists to tan-query #2 #11303

dylanjeffers commented Feb 7, 2025

changeset-bot bot commented Feb 7, 2025 •

edited

Loading

gitguardian bot commented Feb 9, 2025 •

edited

Loading

amendelsohn left a comment

amendelsohn Feb 11, 2025

amendelsohn Feb 11, 2025

amendelsohn Feb 11, 2025

dylanjeffers Feb 12, 2025

[C-5767] Migrate related-artists to tan-query #2 #11303

[C-5767] Migrate related-artists to tan-query #2 #11303

Conversation

dylanjeffers commented Feb 7, 2025

Description

changeset-bot bot commented Feb 7, 2025 • edited Loading

⚠️ No Changeset found

gitguardian bot commented Feb 9, 2025 • edited Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

amendelsohn left a comment

Choose a reason for hiding this comment

amendelsohn Feb 11, 2025

Choose a reason for hiding this comment

amendelsohn Feb 11, 2025

Choose a reason for hiding this comment

amendelsohn Feb 11, 2025

Choose a reason for hiding this comment

dylanjeffers Feb 12, 2025

Choose a reason for hiding this comment

changeset-bot bot commented Feb 7, 2025 •

edited

Loading

gitguardian bot commented Feb 9, 2025 •

edited

Loading