Format number commas in reward notifs (#11356)

Author: dharit-tan

packages/mobile/src/screens/notifications-screen/Notifications/ChallengeRewardNotification.tsx

@@ -4,6 +4,7 @@ import type { BNAudio } from '@audius/common/models'
 import type { ChallengeRewardNotification as ChallengeRewardNotificationType } from '@audius/common/store'
 import {
   challengeRewardsConfig,
+  formatNumberCommas,
   stringWeiToAudioBN
 } from '@audius/common/utils'
 import { Platform } from 'react-native'
@@ -20,7 +21,8 @@ import {
 } from '../Notification'
 
 const messages = {
-  amountEarned: (amount: BNAudio) => `You've earned ${amount} $AUDIO`,
+  amountEarned: (amount: BNAudio) =>
+    `You've earned ${formatNumberCommas(Number(amount.toString()))} $AUDIO`,
   referredText:
     ' for being referred! Invite your friends to join to earn more!',
   challengeCompleteText: ' for completing this challenge!',

packages/web/src/components/notification/Notification/ChallengeRewardNotification.tsx

@@ -2,7 +2,11 @@ import { useCallback } from 'react'
 
 import { Name, BNAudio, ChallengeRewardID } from '@audius/common/models'
 import { ChallengeRewardNotification as ChallengeRewardNotificationType } from '@audius/common/store'
-import { route, stringWeiToAudioBN } from '@audius/common/utils'
+import {
+  formatNumberCommas,
+  route,
+  stringWeiToAudioBN
+} from '@audius/common/utils'
 import { useDispatch } from 'react-redux'
 
 import { make, useRecord } from 'common/store/analytics/actions'
@@ -21,12 +25,11 @@ import { IconRewards } from './components/icons'
 const { REWARDS_PAGE } = route
 
 const messages = {
-  amountEarned: (amount: BNAudio) => `You've earned ${amount} $AUDIO`,
+  amountEarned: (amount: BNAudio) =>
+    `You've earned ${formatNumberCommas(Number(amount.toString()))} $AUDIO`,
   referredText:
     ' for being referred! Invite your friends to join to earn more!',
   challengeCompleteText: ' for completing this challenge!',
-  body: (amount: number) =>
-    `You've earned ${amount} $AUDIO for completing this challenge!`,
   twitterShareText:
     'I earned $AUDIO for completing challenges on @audius #Audius #AudioRewards'
 }