Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA-1891] Fix track tile icon clipping and zero state #11338

Merged
merged 2 commits into from
Feb 11, 2025
Merged

[QA-1891] Fix track tile icon clipping and zero state #11338

merged 2 commits into from
Feb 11, 2025

Conversation

dylanjeffers
Copy link
Contributor

Description

  • Fixes issue where icon-buttons would overflow due to setting padding: 0. probably fine to just apply to icon button
  • Fixes issue where stats zero state height is small due to no content, leading to weird layout of the action buttons. This pretty much only happens on new tracks with no play count

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 5055c8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers dylanjeffers requested review from a team and Kyle-Shanks and removed request for a team February 11, 2025 01:20
@dylanjeffers dylanjeffers merged commit 2fec196 into main Feb 11, 2025
6 checks passed
@dylanjeffers dylanjeffers deleted the qa-1891-icon-clipping branch February 11, 2025 06:07
audius-infra pushed a commit that referenced this pull request Feb 15, 2025
Audius Client (Web and Mobile) v1.5.122
6431d6e 
[341ca35] Fix infinite query return args (#11384) Dylan Jeffers
[82c97e4] [C-5766] Paginate profile collections (#11375) Dylan Jeffers
[5f61f37] [C-5771 QA-1983] Fix harmony white and static white (#11383) Dylan Jeffers
[4cbd971] [C-1984] Improve left-nav buttons with IconButton improvements (#11382) Dylan Jeffers
[4066498] [C-5782, C-5783] Add user comments endpoint and tan query hook (#11366) Kyle Shanks
[96cfea5] [C-5768] New fetch single entity pattern (#11318) Andrew Mendelsohn
[1056ad1] [PAY-3882] Update client collectibles handling (#11312) Randy Schott
[e718ce9] [C5778] Update web profile page layout (#11374) Randy Schott
[b68d0c1] Fix user-link overflow (#11370) Dylan Jeffers
[3d33536] [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) Dylan Jeffers
[77fdd02] Hide endless challenge audio (#11364) Dylan Jeffers
[bfab8f0] [C-5769] Use batch fetching to normalize core entity hooks (#11355) Andrew Mendelsohn
[e85347a] [C-5763 C-5603] Migrate profile collections to tan-query (#11285) Dylan Jeffers
[48ba8aa] [C-5767] Migrate related-artists to tan-query #2 (#11303) Dylan Jeffers
[0c7e2e7] Format number commas in reward notifs (#11356) Reed
[b73cf1f] [PAY-3941] Claim all rewards tile respects optimistic challenges (#11352) Reed
[e9e19d9] Filter out listen streak endless notifications (#11353) Reed
[514ce3f] Don't show oneshot expiry if ineligible (#11351) Reed
[7147843] Ineligible oneshot instead of incomplete on mobile (#11350) Reed
[d053519] Format number commas for all reward amounts (#11349) Reed
[dcca08b] Feature flag on claim all button (#11345) Isaac Solo
[f6aef59] [QA-1909] Fix playlist menu min-width (#11344) Dylan Jeffers
[ac02b23] [QA-1772] Fix windows app frame (#11340) Dylan Jeffers
[6ca3797] [QA-1768] Improve now playing drawer close arrow (#11339) Dylan Jeffers
[1b1f4a8] Update dapp-store build artifacts audius-infra
[2fec196] [QA-1891] Fix track tile icon clipping and zero state (#11338) Dylan Jeffers
[a35337a] Airdrop pt one migration (#11335) Isaac Solo
[3d5c629] [QA-1959] Hide referred tile with new challenge name (#11336) Reed
[dab4766] Fix reward claim error gap too large (#11337) Reed
[7a7c962] Fix harmony and web lint (#11332) Dylan Jeffers
[ce10a10] Bump android version to 468 (#11331) Dylan Jeffers
[42374fe] Fix explore page featured content (#11321) Dylan Jeffers
[97aa11b] Sign out from oauth should not go to trending (#11327) Isaac Solo
[d11f31c] Update airdrop copy and add X icon (#11306) Isaac Solo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amendelsohn amendelsohn amendelsohn approved these changes

@Kyle-Shanks Kyle-Shanks Awaiting requested review from Kyle-Shanks Kyle-Shanks was automatically assigned from AudiusProject/client

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanjeffers @amendelsohn