Format number commas for all reward amounts #11349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dylanjeffers
approved these changes
Feb 11, 2025
dylanjeffers
pushed a commit
that referenced
this pull request
Feb 12, 2025
audius-infra
pushed a commit
that referenced
this pull request
Feb 15, 2025
[341ca35] Fix infinite query return args (#11384) Dylan Jeffers [82c97e4] [C-5766] Paginate profile collections (#11375) Dylan Jeffers [5f61f37] [C-5771 QA-1983] Fix harmony white and static white (#11383) Dylan Jeffers [4cbd971] [C-1984] Improve left-nav buttons with IconButton improvements (#11382) Dylan Jeffers [4066498] [C-5782, C-5783] Add user comments endpoint and tan query hook (#11366) Kyle Shanks [96cfea5] [C-5768] New fetch single entity pattern (#11318) Andrew Mendelsohn [1056ad1] [PAY-3882] Update client collectibles handling (#11312) Randy Schott [e718ce9] [C5778] Update web profile page layout (#11374) Randy Schott [b68d0c1] Fix user-link overflow (#11370) Dylan Jeffers [3d33536] [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) Dylan Jeffers [77fdd02] Hide endless challenge audio (#11364) Dylan Jeffers [bfab8f0] [C-5769] Use batch fetching to normalize core entity hooks (#11355) Andrew Mendelsohn [e85347a] [C-5763 C-5603] Migrate profile collections to tan-query (#11285) Dylan Jeffers [48ba8aa] [C-5767] Migrate related-artists to tan-query #2 (#11303) Dylan Jeffers [0c7e2e7] Format number commas in reward notifs (#11356) Reed [b73cf1f] [PAY-3941] Claim all rewards tile respects optimistic challenges (#11352) Reed [e9e19d9] Filter out listen streak endless notifications (#11353) Reed [514ce3f] Don't show oneshot expiry if ineligible (#11351) Reed [7147843] Ineligible oneshot instead of incomplete on mobile (#11350) Reed [d053519] Format number commas for all reward amounts (#11349) Reed [dcca08b] Feature flag on claim all button (#11345) Isaac Solo [f6aef59] [QA-1909] Fix playlist menu min-width (#11344) Dylan Jeffers [ac02b23] [QA-1772] Fix windows app frame (#11340) Dylan Jeffers [6ca3797] [QA-1768] Improve now playing drawer close arrow (#11339) Dylan Jeffers [1b1f4a8] Update dapp-store build artifacts audius-infra [2fec196] [QA-1891] Fix track tile icon clipping and zero state (#11338) Dylan Jeffers [a35337a] Airdrop pt one migration (#11335) Isaac Solo [3d5c629] [QA-1959] Hide referred tile with new challenge name (#11336) Reed [dab4766] Fix reward claim error gap too large (#11337) Reed [7a7c962] Fix harmony and web lint (#11332) Dylan Jeffers [ce10a10] Bump android version to 468 (#11331) Dylan Jeffers [42374fe] Fix explore page featured content (#11321) Dylan Jeffers [97aa11b] Sign out from oauth should not go to trending (#11327) Isaac Solo [d11f31c] Update airdrop copy and add X icon (#11306) Isaac Solo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
formatNumberCommasanywhere a reward amount is used.Also move the
$to$AUDIO.How Has This Been Tested?
Didn't test mobile cuz couldn't point it to a specific DN.