🪦 poa ganache #11367
Merged
🪦 poa ganache #11367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alecsavvy
requested review from
rickyrombo,
amendelsohn,
raymondjacobson,
phelpsdb,
endline and
dharit-tan
and removed request for
amendelsohn
phelpsdb
approved these changes
Feb 13, 2025
schottra
reviewed
Feb 13, 2025
| web3 = connectedWeb3.web3 | ||
| config.acdcChainId = connectedWeb3.chainId.toString() | ||
| wallets = new WalletManager(web3) | ||
| if (config.environment !== "dev") { |
There was a problem hiding this comment.
Only real concern is that it means we have untestable production code paths. So I guess this means we catch any issues here in staging?
There was a problem hiding this comment.
Yep code path wouldn't change for staging
schottra
added a commit
that referenced
this pull request
Feb 13, 2025
* origin/main: (21 commits) Test listen streak challenge 2 listens in 1 day (#11373) Listen streak challenge fix 2 plays in one day (#11372) Randomize storage node ordering in StorageNodeSelector. (#11371) Disable endless listen streak challenge, delete rows (#11369) Fix user-link overflow (#11370) MRVR country fixes (#11118) [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) 🪦 poa ganache (#11367) Fix playlist invalid sort test (#11368) core block diff health check (#11365) Audius Protocol v0.7.90 Hide endless challenge audio (#11364) [C-5769] Use batch fetching to normalize core entity hooks (#11355) entity manager through core on dev (#11359) fix lint (#11362) Fix plays indexing starvation (#11361) Revert "filter chain health on these nodes" (#11358) Tag audiusd with protocol releases to allow reverts (#11347) [C-5763 C-5603] Migrate profile collections to tan-query (#11285) [C-5767] Migrate related-artists to tan-query #2 (#11303) ...
schottra
added a commit
that referenced
this pull request
Feb 14, 2025
…ibles * origin/main: (71 commits) [PAY-3881][PAY-3883] Add indexing/endpoints for separated collectibles data (#11287) [C5778] Update web profile page layout (#11374) Test listen streak challenge 2 listens in 1 day (#11373) Listen streak challenge fix 2 plays in one day (#11372) Randomize storage node ordering in StorageNodeSelector. (#11371) Disable endless listen streak challenge, delete rows (#11369) Fix user-link overflow (#11370) MRVR country fixes (#11118) [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360) 🪦 poa ganache (#11367) Fix playlist invalid sort test (#11368) core block diff health check (#11365) Audius Protocol v0.7.90 Hide endless challenge audio (#11364) [C-5769] Use batch fetching to normalize core entity hooks (#11355) entity manager through core on dev (#11359) fix lint (#11362) Fix plays indexing starvation (#11361) Revert "filter chain health on these nodes" (#11358) Tag audiusd with protocol releases to allow reverts (#11347) ...
audius-infra
pushed a commit
that referenced
this pull request
Feb 14, 2025
[c8a0e06] [PAY-3881][PAY-3883] Add indexing/endpoints for separated collectibles data (#11287) Randy Schott [1b39bfc] Test listen streak challenge 2 listens in 1 day (#11373) Reed [f854639] Listen streak challenge fix 2 plays in one day (#11372) Reed [c62caf6] Disable endless listen streak challenge, delete rows (#11369) Reed [4773a86] MRVR country fixes (#11118) Steve Perkins [73d3ad1] 🪦 poa ganache (#11367) alecsavvy [f74778f] Fix playlist invalid sort test (#11368) Isaac Solo [1c65e9c] core block diff health check (#11365) alecsavvy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
run this
audius-compose down && npm run protocol && audius-cmd test