Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playlist invalid sort test #11368

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Fix playlist invalid sort test #11368

merged 2 commits into from
Feb 13, 2025

Conversation

isaacsolo
Copy link
Contributor

@isaacsolo isaacsolo commented Feb 13, 2025 •
edited
Loading

Description

Lint may be fixed but tests are still broken.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Will wait for CI to finish this time 😅

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 00b2a3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@isaacsolo isaacsolo requested a review from alecsavvy February 13, 2025 16:57
alecsavvy
alecsavvy approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@alecsavvy alecsavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, was worried about this one. I think the lint was masking it since that short circuits the test workflow

dylanjeffers
dylanjeffers approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you

@isaacsolo isaacsolo enabled auto-merge (squash) February 13, 2025 17:11
@isaacsolo isaacsolo merged commit f74778f into main Feb 13, 2025
6 checks passed
@isaacsolo isaacsolo deleted the is-fix-playlist-test branch February 13, 2025 17:22
schottra added a commit that referenced this pull request Feb 13, 2025
@schottra
Merge remote-tracking branch 'origin/main' into profile-layout-updates
ba7e480 
* origin/main: (21 commits)
  Test listen streak challenge 2 listens in 1 day (#11373)
  Listen streak challenge fix 2 plays in one day (#11372)
  Randomize storage node ordering in StorageNodeSelector. (#11371)
  Disable endless listen streak challenge, delete rows (#11369)
  Fix user-link overflow (#11370)
  MRVR country fixes (#11118)
  [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360)
  🪦 poa ganache (#11367)
  Fix playlist invalid sort test (#11368)
  core block diff health check (#11365)
  Audius Protocol v0.7.90
  Hide endless challenge audio (#11364)
  [C-5769] Use batch fetching to normalize core entity hooks (#11355)
  entity manager through core on dev (#11359)
  fix lint (#11362)
  Fix plays indexing starvation (#11361)
  Revert "filter chain health on these nodes" (#11358)
  Tag audiusd with protocol releases to allow reverts (#11347)
  [C-5763 C-5603] Migrate profile collections to tan-query (#11285)
  [C-5767] Migrate related-artists to tan-query #2 (#11303)
  ...
schottra added a commit that referenced this pull request Feb 14, 2025
@schottra
Merge remote-tracking branch 'origin/main' into update-client-collect…
0deaf9e 
…ibles

* origin/main: (71 commits)
  [PAY-3881][PAY-3883] Add indexing/endpoints for separated collectibles data (#11287)
  [C5778] Update web profile page layout (#11374)
  Test listen streak challenge 2 listens in 1 day (#11373)
  Listen streak challenge fix 2 plays in one day (#11372)
  Randomize storage node ordering in StorageNodeSelector. (#11371)
  Disable endless listen streak challenge, delete rows (#11369)
  Fix user-link overflow (#11370)
  MRVR country fixes (#11118)
  [C-5270 C-5269 C-5268 C-5629] Comment layout improvements (#11360)
  🪦 poa ganache (#11367)
  Fix playlist invalid sort test (#11368)
  core block diff health check (#11365)
  Audius Protocol v0.7.90
  Hide endless challenge audio (#11364)
  [C-5769] Use batch fetching to normalize core entity hooks (#11355)
  entity manager through core on dev (#11359)
  fix lint (#11362)
  Fix plays indexing starvation (#11361)
  Revert "filter chain health on these nodes" (#11358)
  Tag audiusd with protocol releases to allow reverts (#11347)
  ...
audius-infra pushed a commit that referenced this pull request Feb 14, 2025
Audius Protocol v0.7.91
a0c9861 
[c8a0e06] [PAY-3881][PAY-3883] Add indexing/endpoints for separated collectibles data (#11287) Randy Schott
[1b39bfc] Test listen streak challenge 2 listens in 1 day (#11373) Reed
[f854639] Listen streak challenge fix 2 plays in one day (#11372) Reed
[c62caf6] Disable endless listen streak challenge, delete rows (#11369) Reed
[4773a86] MRVR country fixes (#11118) Steve Perkins
[73d3ad1] 🪦 poa ganache (#11367) alecsavvy
[f74778f] Fix playlist invalid sort test (#11368) Isaac Solo
[1c65e9c] core block diff health check (#11365) alecsavvy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanjeffers dylanjeffers dylanjeffers approved these changes

@alecsavvy alecsavvy alecsavvy approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacsolo @dylanjeffers @alecsavvy