Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master 0.1.0 beta review #21

Closed
wants to merge 62 commits into from
Closed

Conversation

tzaeschke
Copy link
Collaborator

@tzaeschke tzaeschke commented Feb 28, 2024

Complete review for 0.1.0 release.


This change is Reviewable

Tilmann Zäschke and others added 30 commits August 14, 2023 10:25
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
test framework + DNS + DatagramChannel

Numerous improvementts: Test framework + DNS + DatagramChannel.

Changes:
-  Improve API
-  DatagramChannel - PingPong server works
-  DatagramSocket - PingPong server works
-  DNS TXT record lookup works
-  Full mock network ("tiny" topology) works for unit tests
-  PathServer API abstraction

---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
tzaeschke and others added 18 commits February 6, 2024 17:03
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>

---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 74.88662% with 443 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (root_init_commit@e650d80). Click here to learn what that means.

❗ Current head a3a9167 differs from pull request most recent head 40a1418. Consider uploading reports for the commit 40a1418 to get more accurate results

Files Patch % Lines
src/main/java/org/scion/ScionService.java 71.42% 39 Missing and 17 partials ⚠️
...ain/java/org/scion/internal/ScionBootstrapper.java 68.82% 37 Missing and 16 partials ⚠️
...ain/java/org/scion/internal/ScionHeaderParser.java 80.97% 20 Missing and 23 partials ⚠️
src/main/java/org/scion/RequestPath.java 43.28% 36 Missing and 2 partials ⚠️
src/main/java/org/scion/PathPolicy.java 24.48% 37 Missing ⚠️
src/main/java/org/scion/internal/Segments.java 84.21% 23 Missing and 13 partials ⚠️
...c/main/java/org/scion/AbstractDatagramChannel.java 86.33% 15 Missing and 7 partials ⚠️
...ain/java/org/scion/internal/InternalConstants.java 54.34% 20 Missing and 1 partial ⚠️
src/main/java/org/scion/Scmp.java 86.84% 16 Missing and 4 partials ⚠️
...main/java/org/scion/internal/PathHeaderParser.java 60.00% 10 Missing and 10 partials ⚠️
... and 14 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##             root_init_commit      #21   +/-   ##
===================================================
  Coverage                    ?   74.88%           
  Complexity                  ?      350           
===================================================
  Files                       ?       26           
  Lines                       ?     1764           
  Branches                    ?      225           
===================================================
  Hits                        ?     1321           
  Misses                      ?      333           
  Partials                    ?      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
tzaeschke and others added 8 commits March 13, 2024 11:11
The DatagramChannel is mixing up the "connected" state of the underlying channel (to first hop) and the implemented channel (to a remote host).

---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
* Global JUnit settings

---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
* /etc/scion/hosts and /etc/resolv.conf

---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
@tzaeschke tzaeschke closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant