ScionService logic #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2024 15:31
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
============================================
- Coverage 72.31% 72.12% -0.20%
+ Complexity 356 355 -1
============================================
Files 28 28
Lines 1860 1858 -2
Branches 233 232 -1
============================================
- Hits 1345 1340 -5
- Misses 403 406 +3
Partials 112 112 ☔ View full report in Codecov by Sentry. |
tzaeschke
added a commit
that referenced
this pull request
Mar 1, 2024
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScionService logic.
Avoid creation of services unless required. Verify that no service is created for server applications.