Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails sporadically #12

Merged
merged 9 commits into from
Feb 9, 2024
Merged

CI fails sporadically #12

merged 9 commits into from
Feb 9, 2024

Conversation

tzaeschke
Copy link
Collaborator

This is not trivially reproducible on developer machines.
The culprit appears to be some kind of race condition in the PingPong tests.

@tzaeschke tzaeschke self-assigned this Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e0166cf) 60.38% compared to head (1d21e81) 60.64%.

Files Patch % Lines
src/main/java/org/scion/ScionService.java 66.66% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage     60.38%   60.64%   +0.26%     
- Complexity      284      285       +1     
============================================
  Files            27       27              
  Lines          1729     1738       +9     
  Branches        219      219              
============================================
+ Hits           1044     1054      +10     
  Misses          593      593              
+ Partials         92       91       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke merged commit 256cbf7 into master Feb 9, 2024
8 checks passed
@tzaeschke tzaeschke deleted the fix/12-sporadic-CI-failure branch February 9, 2024 15:31
tzaeschke added a commit that referenced this pull request Mar 1, 2024
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant