Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCMP cleanup #19

Merged
merged 4 commits into from
Feb 26, 2024
Merged

SCMP cleanup #19

merged 4 commits into from
Feb 26, 2024

Conversation

tzaeschke
Copy link
Collaborator

@tzaeschke tzaeschke commented Feb 26, 2024

SCMP cleanup

@tzaeschke tzaeschke self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.12%. Comparing base (a453513) to head (48f1041).

Files Patch % Lines
src/main/java/org/scion/Scmp.java 80.00% 2 Missing and 1 partial ⚠️
...c/main/java/org/scion/AbstractDatagramChannel.java 0.00% 1 Missing ⚠️
src/main/java/org/scion/internal/ScmpParser.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage     72.12%   72.12%           
  Complexity      355      355           
=========================================
  Files            28       28           
  Lines          1858     1855    -3     
  Branches        232      231    -1     
=========================================
- Hits           1340     1338    -2     
  Misses          406      406           
+ Partials        112      111    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke changed the title SCMP error handling SCMP cleanup Feb 26, 2024
@tzaeschke tzaeschke merged commit 00137a9 into master Feb 26, 2024
8 checks passed
@tzaeschke tzaeschke deleted the fix/19-SCMP-error-handling branch February 26, 2024 13:38
tzaeschke added a commit that referenced this pull request Mar 1, 2024

---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant