Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/etc/scion/hosts and /etc/resolv.conf #40

Merged
merged 14 commits into from
Apr 3, 2024
Merged

Conversation

tzaeschke
Copy link
Collaborator

@tzaeschke tzaeschke commented Apr 2, 2024

Add support for /etc/scion/hosts and /etc/resolv.conf


This change is Reviewable

@tzaeschke tzaeschke self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 81.50685% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 77.49%. Comparing base (c6a0560) to head (c550289).

❗ Current head c550289 differs from pull request most recent head 7e2c1de. Consider uploading reports for the commit 7e2c1de to get more accurate results

Files Patch % Lines
src/main/java/org/scion/ScionService.java 60.00% 9 Missing and 5 partials ⚠️
src/main/java/org/scion/internal/DNSHelper.java 82.97% 5 Missing and 3 partials ⚠️
.../main/java/org/scion/internal/HostsFileParser.java 91.22% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
+ Coverage     75.86%   77.49%   +1.62%     
- Complexity      367      402      +35     
============================================
  Files            26       26              
  Lines          1848     1946      +98     
  Branches        244      260      +16     
============================================
+ Hits           1402     1508     +106     
+ Misses          334      327       -7     
+ Partials        112      111       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke merged commit 40a1418 into master Apr 3, 2024
6 checks passed
@tzaeschke tzaeschke deleted the fix/40-eth-scion-hosts branch April 3, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant