Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCMP refactoring and clean up #14

Merged
merged 13 commits into from
Feb 16, 2024
Merged

SCMP refactoring and clean up #14

merged 13 commits into from
Feb 16, 2024

Conversation

tzaeschke
Copy link
Collaborator

SCMP refactoring and cleanup

  • Rename Scmp.ScmpXYZ to Scmp.XYZ
  • Remove Result<>
  • Move Scmp code out of DatagramChannel into separate class. Consider creating AbstractScionChannel.

@tzaeschke tzaeschke self-assigned this Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (1f33b10) 70.41% compared to head (6167c0e) 70.99%.

Files Patch % Lines
src/main/java/org/scion/ScmpDatagramChannel.java 0.00% 25 Missing ⚠️
...c/main/java/org/scion/AbstractDatagramChannel.java 86.75% 13 Missing and 7 partials ⚠️
src/main/java/org/scion/Scmp.java 87.50% 3 Missing and 2 partials ⚠️
...ain/java/org/scion/internal/ScionBootstrapper.java 33.33% 2 Missing ⚠️
src/main/java/org/scion/DatagramChannel.java 95.45% 0 Missing and 1 partial ⚠️
src/main/java/org/scion/ScmpChannel.java 98.52% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #14      +/-   ##
============================================
+ Coverage     70.41%   70.99%   +0.57%     
- Complexity      336      349      +13     
============================================
  Files            27       29       +2     
  Lines          1795     1879      +84     
  Branches        229      228       -1     
============================================
+ Hits           1264     1334      +70     
- Misses          425      441      +16     
+ Partials        106      104       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke merged commit 7ff76e7 into master Feb 16, 2024
8 checks passed
@tzaeschke tzaeschke deleted the fix/14-scmp-cleanup branch February 16, 2024 15:11
tzaeschke added a commit that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant