Skip to content

Commit

Permalink
SCMP refactoring and clean up (#14)
Browse files Browse the repository at this point in the history
  • Loading branch information
tzaeschke authored and Tilmann Zäschke committed Mar 1, 2024
1 parent 1ae919b commit 55b89d9
Show file tree
Hide file tree
Showing 19 changed files with 914 additions and 627 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Changed
- BREAKING CHANGE: Changed maven artifactId to "client"
[#9](https://github.com/tzaeschke/phtree-cpp/pull/9)
- BREAKING CHANGE: SCMP refactoring, renamed several SCMP related classes.
[#14](https://github.com/tzaeschke/phtree-cpp/pull/14)

### Fixed
- Fixed SCMP timeout and error handling (IOExceptions + SCMP errors).
Expand Down
1 change: 1 addition & 0 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ Discuss required for 0.1.0:
- Selector support
- Implement interfaces from nio.DatagramChannel
- Look into Selectors: https://www.baeldung.com/java-nio-selector
- Consider sublcassing DatagramChannel directly.
- Consider SHIM support. SHIM is a compatibility component that supports
old border-router software (requiring a fixed port on the client, unless
the client is listening on this very port). When SHIM is used, we cannot
Expand Down
3 changes: 2 additions & 1 deletion doc/Design.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ We should look at other custom Java protocol implementations, e.g. for QUIC:
## Daemon
The implementation can use the daemon. Alternatively, since daemon installation may
be cumbersome on platforms such as Android, we can directly connect to a control service.

An alternative for mobile devices could be a non-local daemon that is hosted by the mobile provider.
This may work but may open opportunities for side-channel attacks on the daemon.
Also, when roaming, the provider may not actually support SCION. In this case the
Expand All @@ -27,7 +28,7 @@ at least a topology server + control server.
- Use Junit 5.
- Use Google style guide for code
- We use custom exceptions. However, to make the API as compatible with standard networking API
as possible, our Exceptions extend either IOException or RuntimeExcdeption.
as possible, our Exceptions extends either IOException or RuntimeException.

## Paths

Expand Down
Loading

0 comments on commit 55b89d9

Please sign in to comment.