Segment cleanup

[tzaeschke]

Clean up segment logic and testing

[codecov]

Codecov Report

Attention: Patch coverage is 81.32530% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 72.13%. Comparing base (1ed3503) to head (0c091ab).

❗ Current head 0c091ab differs from pull request most recent head 322ead9. Consider uploading reports for the commit 322ead9 to get more accurate results

Files	Patch %	Lines
src/main/java/org/scion/internal/Segments.java	80.28%	17 Missing and 11 partials ⚠️
src/main/java/org/scion/ScionService.java	82.35%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     72.12%   72.13%           
+ Complexity      355      347    -8     
=========================================
  Files            28       28           
  Lines          1855     1823   -32     
  Branches        231      223    -8     
=========================================
- Hits           1338     1315   -23     
+ Misses          406      398    -8     
+ Partials        111      110    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.