TODOs

scionproto-contrib · Feb 28, 2024 · 322ead9 · 322ead9
1 parent 0c091ab
commit 322ead9
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 9 deletions.
diff --git a/src/main/java/org/scion/AbstractDatagramChannel.java b/src/main/java/org/scion/AbstractDatagramChannel.java
@@ -301,18 +301,20 @@ public synchronized <T> C setOption(SocketOption<T> option, T t) throws IOExcept
       } else {
         throw new UnsupportedOperationException();
       }
-    } else if (StandardSocketOptions.SO_RCVBUF.equals(option)) {
-      // TODO resize buf
-      channel.setOption(option, t);
-    } else if (StandardSocketOptions.SO_SNDBUF.equals(option)) {
-      // TODO resize buf
+    } else if (StandardSocketOptions.SO_RCVBUF.equals(option)
+        || StandardSocketOptions.SO_SNDBUF.equals(option)) {
       channel.setOption(option, t);
+      resizeBuffers(
+          channel.getOption(StandardSocketOptions.SO_RCVBUF),
+          channel.getOption(StandardSocketOptions.SO_SNDBUF));
     } else {
       channel.setOption(option, t);
     }
     return (C) this;
   }
 
+  protected abstract void resizeBuffers(int sizeReceive, int sizeSend);
+
   /**
    * @param path path
    * @param payloadLength payload length

diff --git a/src/main/java/org/scion/DatagramChannel.java b/src/main/java/org/scion/DatagramChannel.java
@@ -26,8 +26,8 @@
 public class DatagramChannel extends AbstractDatagramChannel<DatagramChannel>
     implements ByteChannel, Closeable {
 
-  private final ByteBuffer bufferReceive;
-  private final ByteBuffer bufferSend;
+  private ByteBuffer bufferReceive;
+  private ByteBuffer bufferSend;
 
   protected DatagramChannel(ScionService service, java.nio.channels.DatagramChannel channel)
       throws IOException {
@@ -61,6 +61,16 @@ public synchronized boolean isBlocking() {
     return super.isBlocking();
   }
 
+  @Override
+  protected void resizeBuffers(int sizeReceive, int sizeSend) {
+    if (bufferReceive.capacity() != sizeReceive) {
+      bufferReceive = ByteBuffer.allocateDirect(sizeReceive);
+    }
+    if (bufferSend.capacity() != sizeSend) {
+      bufferSend = ByteBuffer.allocateDirect(sizeSend);
+    }
+  }
+
   public synchronized ResponsePath receive(ByteBuffer userBuffer) throws IOException {
     ResponsePath receivePath = receiveFromChannel(bufferReceive, InternalConstants.HdrTypes.UDP);
     if (receivePath == null) {

diff --git a/src/main/java/org/scion/ScmpChannel.java b/src/main/java/org/scion/ScmpChannel.java
@@ -127,8 +127,8 @@ private interface IOCallable<V> {
   }
 
   private class InternalChannel extends AbstractDatagramChannel<InternalChannel> {
-    private final ByteBuffer bufferReceive;
-    private final ByteBuffer bufferSend;
+    private ByteBuffer bufferReceive;
+    private ByteBuffer bufferSend;
     private final Selector selector;
 
     protected InternalChannel(ScionService service, RequestPath path, int port) throws IOException {
@@ -227,6 +227,16 @@ private ResponsePath receiveWithTimeout(ByteBuffer buffer) throws IOException {
       }
     }
 
+    @Override
+    protected void resizeBuffers(int sizeReceive, int sizeSend) {
+      if (bufferReceive.capacity() != sizeReceive) {
+        bufferReceive = ByteBuffer.allocateDirect(sizeReceive);
+      }
+      if (bufferSend.capacity() != sizeSend) {
+        bufferSend = ByteBuffer.allocateDirect(sizeSend);
+      }
+    }
+
     @Override
     public void close() throws IOException {
       super.close();