Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More SCMP cleanup #17

Merged
merged 7 commits into from
Feb 23, 2024
Merged

More SCMP cleanup #17

merged 7 commits into from
Feb 23, 2024

Conversation

tzaeschke
Copy link
Collaborator

No description provided.

@tzaeschke tzaeschke self-assigned this Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 72.31%. Comparing base (03ad5d9) to head (387e4da).

❗ Current head 387e4da differs from pull request most recent head 1939213. Consider uploading reports for the commit 1939213 to get more accurate results

Files Patch % Lines
...ain/java/org/scion/internal/ScionHeaderParser.java 66.66% 2 Missing and 3 partials ⚠️
src/main/java/org/scion/ScmpChannel.java 87.09% 1 Missing and 3 partials ⚠️
src/main/java/org/scion/Scmp.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
+ Coverage     71.63%   72.31%   +0.67%     
- Complexity      355      356       +1     
============================================
  Files            28       28              
  Lines          1844     1860      +16     
  Branches        231      233       +2     
============================================
+ Hits           1321     1345      +24     
+ Misses          413      403      -10     
- Partials        110      112       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzaeschke tzaeschke merged commit 08e4267 into master Feb 23, 2024
6 checks passed
@tzaeschke tzaeschke deleted the fix/17-more-SCMP branch February 23, 2024 13:16
tzaeschke added a commit that referenced this pull request Mar 1, 2024
---------

Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant