[Release] Stage to Main #2811 #72

mokimo · 2024-09-03T15:59:11Z

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

…L instead of just fragments (adobecom#2683) * getSelectedElement - V2 * getSelectedElement - V2 * getSelectedElement - V2 * getSelectedElement - V2 * getSelectedElement - V2 * added test coverage for action * cleanup * added comments * comments * comments * fixes erroring but still has failure * rooEl fix * fixed tests * added modifier * eslint * lint * removed reduncant try catch * Add target analytics for update action * removed test-results and added to .gitignore * reverted a deletion of a prependtosection validation code * removed comments * updated validation for appendtosdection * removed comments and eslint escapes * change modifier to an array that is not a separate column * add highight for update * add timeout to merch-card highlight * remove setTimeout and move preview.js call from loadPostLCP to loadDeferred * update unit test * remove update to git ignore * add temp console message for easy QA * MWPW-155566 [MEP] Changing from a new action to just expanding power of existing actions (adobecom#2764) * stash * use replace instead of update, allow html for create commands, update simplified selectors * streamline * remove export on MILO_BLOCKS * change prependToSection and appendToSection to just prepend and append * remove unused function param * change from includes to === * remove use of .parentElement * move spoof param test so you can reload the other tests * account for number used after dot notation * add test to insertbefore and insert after href * more coverage * more coverage * hopefully final coverage * remove console * rename checkSelectorType to getSelectorType * move parts of createContent into sub functions * small big fix * update modifySelectorTerm function per suggestion * update modifyNonFragmentSelector per suggestion * update to getSelectedElement * change equal to not equal * fix end number update * codecov * no longer require fragments be in URL for fragments because of gnav * call getModifiers in modifyNonFragmentSelector instead * require space before first flag * update unit tests to need space before flags * handle adding flags to fragment selectors * revert for demo * put back * remove utils update so it does not conflict --------- Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local> Co-authored-by: vgoodric <vgoodric@adobe.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>

…MD (adobecom#2765) * Add charlimit for headers analytics * Fix header for integer value only * Update libs/martech/attributes.js set header length to false for clarity Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> * Add tests * Refacter str null check per suggestion * Fix test coverage --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>

* MWPW-145727: add configurator changes for alt cta on live events * MWPW-14572: get the alt cta from secondaryCTA so it can be localized by caas * lint * left something in * left something in * unit tests * unit tests * MWPW-145727: unit tests * MWPW-145727: unit tests * MWPW-145727: unit tests * MWPW-145727: unit tests * unit tests hopefully * ok finally the unit tests probably * ok this will be the one * variable name * config hash test --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Sheridan Sunier <sunier@Sheridans-MacBook-Pro.local>

…com#2723) * add sitemap * remove pandora wcs client * remove obsolete dependencies * fix request&settings test * remove domainSwitch * fix tests * update deps * fix review comment * use usual error message * fix language param * commit packag-lock * bring back transitive dependencies * bring back www.stage.adobe.com * omit cookies for wcs requests * revert special logic for stage

* hero bugz updates * added wrapInnerHTMLInPTag for single line entries * changed order to wrapInnerinP so it happens before decorateButtons * PR feedback * PR feedback - minor logic fix for potential null value * minor fix, missing scope for flex dir col for .bg-bottom-tablet * missing selector for bg-bottom-tablet btm padding * Fixed scope so row-lockup also gets iconography.css * PR feedback, shorten some code logic * await loadIconography

* gnav dark theme init * Dark gnav icon changes * Dark gnav changes * add theme in standalone gnav config * allow 2 logo for dark mode * UTs for gnav dark theme * UTs for gnav dark theme * Dark gnav color changes * gnav dark mode refactor css * gnav dark mode refactor css * load darknav after base to override variables * update darknav promo css * lightmode promobar link color * update region nav link color * update nav background color for darkmode * fix outline for windows * update darknav css

…red (adobecom#2770) * move call for preview from loadPostLCP to loadDeferred * change function name to getSelectorType * revert

adobecom#2772) * branch banner ecid * review changes * passing ecid value --------- Co-authored-by: Drashti Modasara <dmodasara@adobe.com>

* update button decorator to handle custom classes * add dash character to regex * add coverage * add safeguard for href-less buttons * account for modals * Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux)" (adobecom#2777) Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux) (adobecom#2767)" This reverts commit 88cb101. * add modal coverage * Revert "Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux)" (adobecom#2777)" This reverts commit b1a3948.

* adjustment to colors for better contrast * aria-label for carousel arrows * css clean up Resolves: [MWPW-156126](https://jira.corp.adobe.com/browse/MWPW-156126)

* nala initial commit * gitignore * updated the tests * update to the packages * updating util file * remove new line * update base-reporter.js * update geo pom * update nala run * update git ignore * fixing eslint errors * eslint fixes --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@santoshumarsmbp.corp.adobe.com> Co-authored-by: Santoshkumar Sharanappa Nateekar <nateekar@Santoshkumars-MacBook-Pro.local>

Eagerly import lit from merch-card block

* MWPW-157005 Marketo thank you fixes * PR Changes

mwpw-156840: parallelize loading placeholders

…dobecom#2800) * poc for up-tablet * moved one-up to approp mq * remove redundant two-up-tablet. Use min-max defaults

) * fix(a11y): added a11y two header tables * fix(heading): fixing the first row as columnheader * fix: heading more describable * fix(table): dynamic id added * fix: unique id for header body,pricing tag * chore: code opt * chore: eslint fix * fix(tab-focus): fixed key event in expand section * fix: review changes

… are used in non EN page (adobecom#2780) * Initial checkin - Working state. * Optimization. Good State. * Semi-colon fix. * Linting fixes. * Unit test file creation. * Placeholders update/fix. * Fixed US data values. * Unit testing WIP. * fix unit test * unit test working * add before each * fix linter issue of using same name above * update processTrackingLabels * add coverage to attributes.js unit test * Unit test updates. --------- Co-authored-by: vgoodric <vgoodric@adobe.com>

aem-code-sync · 2024-09-03T15:59:15Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

7216452 ❌ (latest)
47dea19 ❌
bc61484 ❌
8b62e93 ❌
3ad052c ❌
3331e11 ❌
582c244 ❌
fc58707 ❌
76a1344 ❌
e675bf4 ❌
4e85f88 ❌
77268c0 ❌
ad50e4b ❌
10cfc4b ❌
3551ffd ❌
5417762 ❌
1c4001b ❌
d405ac1 ❌
8467b03 ❌
42d51a0 ❌
6362c19 ❌

aem-code-sync · 2024-09-03T15:59:33Z

	Page	Scores	Audits	Google
M	/?martech=off
D	/?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/mokimo/milo/blob/721645234c38ae69cf110e5b822ce4cc29ea821a/libs/features/mas/commerce/src/settings.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/mokimo/milo/blob/721645234c38ae69cf110e5b822ce4cc29ea821a/libs/features/mas/commerce/src/wcs.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/mokimo/milo/blob/721645234c38ae69cf110e5b822ce4cc29ea821a/libs/features/mas/commerce/test/settings.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/mokimo/milo/blob/721645234c38ae69cf110e5b822ce4cc29ea821a/libs/features/mas/commerce/test/wcs.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/mokimo/milo/blob/721645234c38ae69cf110e5b822ce4cc29ea821a/libs/features/mas/web-components/src/merch-mnemonic-list.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/mokimo/milo/blob/721645234c38ae69cf110e5b822ce4cc29ea821a/libs/features/mas/web-components/src/merch-whats-included.js

⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

milo/libs/navigation/navigation.js

Line 43 in 7216452

    
           console.error('Global navigation Error: header and footer configurations are missing.');

github-actions · 2024-09-03T15:59:50Z

nala/blocks/accordion/accordion.test.js

+
+  // Test 0 : Accordion Container
+  test(`${features[0].name},${features[0].tags}`, async ({ page, baseURL }) => {
+    console.info(`[Test Page]: ${baseURL}${features[0].path}${miloLibs}`);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-03T15:59:50Z

nala/blocks/accordion/accordion.test.js

+
+  // Test 1 : Accordion (seo)
+  test(`${features[1].name},${features[1].tags}`, async ({ page, baseURL }) => {
+    console.info(`[Test Page]: ${baseURL}${features[1].path}${miloLibs}`);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-03T15:59:51Z

nala/blocks/accordion/accordion.test.js

+        return scriptElement ? scriptElement.textContent : null;
+      });
+      expect(scriptContent).toBeTruthy();
+      console.log('[SEO Script content]:', scriptContent);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-03T15:59:51Z

nala/blocks/accordion/accordion.test.js

+
+  // Test 2 : Accordion (quiet, max-width-12-desktop-large)
+  test(`${features[2].name},${features[2].tags}`, async ({ page, baseURL }) => {
+    console.info(`[Test Page]: ${baseURL}${features[2].path}${miloLibs}`);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-03T15:59:51Z

nala/blocks/accordion/accordion.test.js

+
+  // Test 3 : Accordion seo editorial
+  test(`${features[3].name},${features[3].tags}`, async ({ page, baseURL }) => {
+    console.info(`[Test Page]: ${baseURL}${features[3].path}${miloLibs}`);


⚠️ [eslint] <no-console> _{reported by reviewdog 🐶}
Unexpected console statement.

github-actions · 2024-09-03T15:59:52Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T15:59:53Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T15:59:54Z

libs/deps/mas/merch-mnemonic-list.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T15:59:55Z

libs/deps/mas/merch-whats-included.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T15:59:55Z

libs/features/mas/commerce/libs/commerce.d.ts

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T15:59:56Z

libs/features/mas/commerce/src/constants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T15:59:57Z

libs/features/mas/commerce/src/defaults.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T15:59:58Z

libs/features/mas/commerce/src/external.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T15:59:59Z

libs/features/mas/commerce/src/index.d.ts

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-03T16:00:00Z

libs/features/mas/commerce/src/index.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

denlight and others added 21 commits September 2, 2024 08:17

MWPW-157540: fix external modals (adobecom#2806)

8467b03

Mwpw 142267: What's included style fixes (adobecom#2674)

d405ac1

MWPW-157034 [MEP] move call for preview from loadPostLCP to loadDefer…

ad50e4b

…red (adobecom#2770) * move call for preview from loadPostLCP to loadDeferred * change function name to getSelectorType * revert

[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation (

77268c0

adobecom#2772) * branch banner ecid * review changes * passing ecid value --------- Co-authored-by: Drashti Modasara <dmodasara@adobe.com>

MWPW-156126 - quiz-entry contrast and accessibility (adobecom#2785)

e675bf4

* adjustment to colors for better contrast * aria-label for carousel arrows * css clean up Resolves: [MWPW-156126](https://jira.corp.adobe.com/browse/MWPW-156126)

[MWPW-157556] Eagerly import lit from merch-card block (adobecom#2809)

fc58707

Eagerly import lit from merch-card block

MWPW-157005 Marketo thank you fixes (adobecom#2779)

582c244

* MWPW-157005 Marketo thank you fixes * PR Changes

[MWPW-148140] Adjust table strikethrough pricing (adobecom#2786)

3331e11

Parallelize Placeholder loading for an LCP improvement (adobecom#2752)

3ad052c

mwpw-156840: parallelize loading placeholders

MWPW-151932 - Section metadata style grid enhancement for tablet VP (a…

8b62e93

…dobecom#2800) * poc for up-tablet * moved one-up to approp mq * remove redundant two-up-tablet. Use min-max defaults

MWPW-157445 Additional Lana LCP data (adobecom#2805)

7216452

github-actions bot reviewed Sep 3, 2024

View reviewed changes

mokimo merged commit e61a972 into main Sep 3, 2024
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] Stage to Main #2811 #72

[Release] Stage to Main #2811 #72

mokimo commented Sep 3, 2024

aem-code-sync bot commented Sep 3, 2024

aem-code-sync bot commented Sep 3, 2024

github-actions bot left a comment

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

github-actions bot Sep 3, 2024

[Release] Stage to Main #2811 #72

[Release] Stage to Main #2811 #72

Conversation

mokimo commented Sep 3, 2024

common base root URLs

aem-code-sync bot commented Sep 3, 2024

aem-code-sync bot commented Sep 3, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment

github-actions bot Sep 3, 2024

Choose a reason for hiding this comment