Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154448: Content should be in a data table but is not #2667

Merged
merged 11 commits into from
Sep 3, 2024

Conversation

Copy link
Contributor

aem-code-sync bot commented Jul 31, 2024

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (d90dcc0) to head (8e299f1).
Report is 22 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2667      +/-   ##
==========================================
- Coverage   95.90%   95.90%   -0.01%     
==========================================
  Files         173      173              
  Lines       45842    45868      +26     
==========================================
+ Hits        43967    43988      +21     
- Misses       1875     1880       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Aug 9, 2024
libs/blocks/table/table.js Outdated Show resolved Hide resolved
libs/blocks/table/table.js Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Aug 15, 2024
@sivasadobe sivasadobe requested a review from drashti1712 August 19, 2024 05:10
@drashti1712
Copy link
Contributor

@sivasadobe Could you please fix the unit tests for this PR?

@sivasadobe
Copy link
Contributor Author

@sivasadobe Could you please fix the unit tests for this PR?

Fixed.
Could you review again.

@sivasadobe sivasadobe added the needs-verification PR requires E2E testing by a reviewer label Aug 28, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

@PavanKumarN8
Copy link

I have verified the PR on the Chrome browser.
Content present below 'Apps' text is marked as data table.
Attached evidence in Jira - https://jira.corp.adobe.com/browse/MWPW-156659

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Sep 3, 2024
@milo-pr-merge milo-pr-merge bot merged commit bc61484 into adobecom:stage Sep 3, 2024
25 checks passed
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants