MWPW-156126 - quiz-entry contrast and accessibility #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adjustment to colors for better contrast * aria-label for carousel arrows * css clean up Resolves: [MWPW-156126](https://jira.corp.adobe.com/browse/MWPW-156126)
|
mokimo
approved these changes
Aug 26, 2024
| @@ -144,7 +144,7 @@ export const GetQuizOption = ({ | |||
|
|
|||
| return html` | |||
| <div class="quiz-options-container" role="group" aria-labelledby="question" tabindex="0" onkeydown=${handleKey}> | |||
| ${index > 0 && html`<button onClick=${prev} class="carousel-arrow arrow-prev ${isRTL ? 'rtl' : ''}"></button>`} | |||
| ${index > 0 && html`<button onClick=${prev} class="carousel-arrow arrow-prev ${isRTL ? 'rtl' : ''}" aria-label="Previous"></button>`} | |||
There was a problem hiding this comment.
Ideally, this should be translated as well for other locales
There was a problem hiding this comment.
Great suggestion! Of course we can work out translation like this, but it would be more involved because we would need to incorporate it into the strings spreadsheet. I'll have to write up a followup ticket for that, but there's a release deadline for US and they need these basic issues to be corrected first.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2785 +/- ##
=======================================
Coverage 95.90% 95.91%
=======================================
Files 173 173
Lines 45842 45842
=======================================
+ Hits 43967 43968 +1
+ Misses 1875 1874 -1 ☔ View full report in Codecov by Sentry. |
JackySun9
approved these changes
Aug 26, 2024
robert-bogos
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-156126
Test URLs: