MWPW-157346:[NALA] Move Nala tests to Milo repository #2795
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2795 +/- ##
==========================================
- Coverage 95.90% 95.90% -0.01%
==========================================
Files 173 173
Lines 45842 45842
==========================================
- Hits 43967 43966 -1
- Misses 1875 1876 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
|
skumar09
requested review from
narcis-radu,
overmyheadandbody,
Dli3,
mokimo,
amauch-adobe and
JackySun9
There was a problem hiding this comment.
Cool a couple of points and questions:
- Should we update the workflow to always run on the milo repo?
- I guess the consumer tests will also be moved soon?
I'd recommend adding the nala folder https://github.com/adobecom/milo/blob/stage/.github/workflows/label-zero-impact.js#L2-L17 to this workflow. Zero-impact PRs are generally mergeable faster and with less hassle.
|
|
||
| if (process.env.SLACK_WH) { | ||
| try { | ||
| await sendSlackMessage(process.env.SLACK_WH, resultSummary); |
There was a problem hiding this comment.
Is the SLACK_WH added to this repo?
| const totalTests = this.results.length; | ||
| const passPercentage = ((this.passedTests / totalTests) * 100).toFixed(2); | ||
| const failPercentage = ((this.failedTests / totalTests) * 100).toFixed(2); | ||
| const miloLibs = process.env.MILO_LIBS || ''; |
There was a problem hiding this comment.
Same with the other process variables, have they been added to milo as well?
There was a problem hiding this comment.
Same with the other process variables, have they been added to milo as well?
-> This process variable is set/updated as part ofrun-nala-tests-on-milolibsGitHub action flow,
| @@ -0,0 +1,71 @@ | |||
| /* eslint-disable import/no-extraneous-dependencies */ | |||
There was a problem hiding this comment.
Should we move the playwright config file to nala? Since we also use it for WTR, it might lead to confusion otherwise
There was a problem hiding this comment.
@mokimo: Once we move all Milo Nala tests, and add/update the GitHub action flow to run Nala tests from the Milo repo, i will move this under the Nala folder or change the file name to nala.config.js
|
Move Nala UI tests to the Milo repository.
- Local env
- Libs env
- Milolibs
- Stage, Main, feature branch, or any environments
Resolves: MWPW-157346
** Nala Run Command**
Test URLs:
Note: