[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation #2772
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2772 +/- ##
=======================================
Coverage 95.91% 95.92%
=======================================
Files 173 173
Lines 45831 45861 +30
=======================================
+ Hits 43958 43990 +32
+ Misses 1873 1871 -2 ☔ View full report in Codecov by Sentry. |
| const performanceCookieConsent = cookieGrp.includes('C0002'); | ||
| const advertisingCookieConsent = cookieGrp.includes('C0004'); | ||
|
|
||
| if (performanceCookieConsent && advertisingCookieConsent && isAndroid) branch.setBranchViewData({ data: { ecid: ecidVal }}); |
There was a problem hiding this comment.
legal requirement as far as I remember
| @@ -63,5 +81,7 @@ export default async function init(el) { | |||
| const classListArray = Array.from(el.classList); | |||
| const product = classListArray.find((token) => token.startsWith('product-')).split('-')[1]; | |||
| const key = await getKey(product); | |||
| if (key) branchInit(key); | |||
| if (!key) return; | |||
| const ecid = await getECID(); | |||
There was a problem hiding this comment.
you can get the ecid directly in the branchInit method, no need to pass the value.
|
This PR is currently in the |
|
Validation done on the pr in the below url : details are updated in ticket |
spadmasa
added
verified
Resolves: MWPW-152968
Test URLs: